Repository navigation
Send optimistic transactionThreadReportID and createdReportActionIDForThread with API commands RequestMoney, CreateDistanceRequest, CompleteSplitBill, SendMoney #31411
Description
Activity
@cdanwards can you comment here so I can assign you?
Commenting for Assignment
@cdanwards Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
@cdanwards Eep! 4 days overdue now. Issues have feelings too...
No update.
@cdanwards Huh... This is 4 days overdue. Who can take care of this?
Next in line for work
56 remaining items
Triggered auto assignment to @johncschuster (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.@johncschuster please issue payment to C+ @situchan for PR review. Thanks!
Reacted by John Schuster⚠️ Looks like this issue was linked to a Deploy Blocker hereIf you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
@cead22 it looks like this issue was linked to a deploy blocker. Has that been resolved, or do I need to wait on issuing payment?
Payment Summary:
Contributor: @cdanwards - Contractor
C+ Reviewer: @situchan - $500 - Upwork job offerPaid!
Triggered auto assignment to @cead22 , see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.
📣 @BiswaJK! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:- Make sure you've read and understood the contributing guidelines.
- Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
- Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
- Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details Your Expensify account email: <REPLACE EMAIL HERE> Upwork Profile Link: <REPLACE LINK HERE>
ReportUtils.buildTransactionThread// TODO add logic to create transaction thread for each DM between split participantsbuildOnyxDataForMoneyRequestinsidecompleteSplitBilllike we do ingetMoneyRequestInformationoptimisticCreatedAction.reportIDas the last param to thebuildOnyxDataForMoneyRequestcalltransactionThreadReportID: transactionThread.reportIDandcreatedReportActionIDForThread: optimisticCreatedAction.reportActionIDto the params object we pass toAPI.write(‘CompleteSplitBill’, {params})