[HOLD for payment 2023-11-29] [$125] Desktop - Avatars in split preview card too close to right edge

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.99.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1700000146978699

Action Performed:

1. Create a split with two other people
2. Look at the preview card

Expected Result:

Avatar stacak should be 20px (or is it 16px?) away from the right edge of the card, it should match the same padding as left side

Actual Result:

Avatar stack is too close to right edge

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

2023-11-15.1.10.24.PM.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014ce3040ec2425cf6
• Upwork Job ID: 1724853684623753216
• Last Price Increase: 2023-11-15
• Automatic offers:
• paultsimura | Contributor | 27689355

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014ce3040ec2425cf6

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[melvin-bot]

Upwork job price has been updated to $125

[youssef-lr]

I'm going to try and fix this in an ongoing PR. If not we can let this be external.

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The avatars are incorrectly placed

What is the root cause of that problem?

The avatars use the negative margin here, which was added in 2021 (#2112), but now seems like a redundant code:

App/src/styles/styles.ts

Lines 2661 to 2664 in e953a65

	moneyRequestPreviewBoxAvatar: {
	marginRight: -10,
	marginBottom: 0,
	},

What changes do you think we should make in order to solve the problem?

We actually can remove the special style here:

App/src/components/ReportActionItem/MoneyRequestPreview.js

Line 312 in c536053

<View style={styles.moneyRequestPreviewBoxAvatar}>

And the moneyRequestPreviewBoxAvatar style altogether.

What alternative solutions did you explore? (Optional)