Repository navigation
MEDIUM: [$500] Unread indicator is showing in the fevicon even though there is nothing in LHN #31276
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1699899029212629
Action Performed:
- Open app and login
- Make a IOU request
- Open the IOU thread to see the details
- Observe the unread indicator in expensify fevicon
Expected Result:
If there is an unread indicator, LHN should have one unread message
Actual Result:
But nothing in LHN with unread message.
it was caused by this transaction thread, which wasn’t showing up in my LHN, but was considered unread by the logic being used to compute the unread indicator here. We should update the logic of the unread indicator to make sure it matches the logic of the LHN (or even better use shared logic). So that it’s never possible to see the unread indicator when you don’t have anything unread in the LHN.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01d98ea368e18737bf
- Upwork Job ID: 1724168903941550080
- Last Price Increase: 2024-01-03
Issue Owner
Current Issue Owner: @muttmuureMetadata
Metadata
Assignees
Labels
Type
Projects
- Status
Activity
[-]Unread indicator is showing in the fevicon eventhough there is nothing in LHN[/-][+][$500] Unread indicator is showing in the fevicon eventhough there is nothing in LHN[/+]melvin-bot commentedon Nov 13, 2023
Triggered auto assignment to @miljakljajic (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Nov 13, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01d98ea368e18737bf
melvin-bot commentedon Nov 13, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Nov 13, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (
External)89 remaining items
MonilBhavsar commentedon Jan 29, 2024
PR merged and deployed to production. Taking this off hold.
[-][HOLD App PR 34025]MEDIUM: [$500] Unread indicator is showing in the fevicon even though there is nothing in LHN[/-][+]MEDIUM: [$500] Unread indicator is showing in the fevicon even though there is nothing in LHN[/+]MonilBhavsar commentedon Jan 29, 2024
Have asked if bug is fixed or not in slack thread https://expensify.slack.com/archives/C049HHMV9SM/p1706532316571099?thread_ts=1699899029.212629&cid=C049HHMV9SM
melvin-bot commentedon Jan 29, 2024
@MonilBhavsar, @muttmuure, @situchan Eep! 4 days overdue now. Issues have feelings too...
iwiznia commentedon Jan 29, 2024
This has been working for me for a while now https://expensify.slack.com/archives/C03U7DCU4/p1706112016224459
muttmuure commentedon Jan 30, 2024
It seems like there are a few PRs that will be eligible for payment here, I need to comb through and figure it out
muttmuure commentedon Feb 2, 2024
OK, so the linked issue was a fix for a regression - #33506 so no payment there.
We did get a proposal for this issue above, but since there was an overlap with the regression fix, there was already something solid and we actually didn't need the second proposal.
So I am going to close this, but if you think that your work was eligible for payment despite this issue not having a linked PR, please send me a DM!