Skip to content

[HOLD for payment 2023-11-22] [HOLD for payment 2023-11-21] Workspace - Start over page is not shown when user quits bank account setup and revisits it #31212

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.98.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Go to Settings > Workspaces > any workspace.
  3. Click Bank account.
  4. Click Connect manually.
  5. Proceed until Step 3 of bank account setup.
  6. Close the setup by clicking outside the RHN.
  7. Go to Settings > Workspaces > any workspace.
  8. Click Bank account.

Expected Result:

User will be presented with 'Continue with setup' and 'Start over' screen.

Actual Result:

User is redirected to where the bank account setup is left off.
In order to see 'Continue with setup' and 'Start over' screen, user has to return to the first screen.
On PROD, user is presented with 'Continue with setup' and 'Start over' screen after closing the setup and revisiting bank account page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6271756_1699647092519.20231111_024250__1_.mp4

View all open jobs on GitHub

Activity

  1. OSBotify commented on Nov 10, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Nov 10, 2023

    @melvin-bot

    Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. johnmlee101 commented on Nov 10, 2023

    @johnmlee101
    Contributor

    #29166 might be related

  4. johnmlee101 commented on Nov 10, 2023

    @johnmlee101
    Contributor

    Asked in deployer for some extra 👀

  5. johnmlee101 commented on Nov 10, 2023

    @johnmlee101
    Contributor

    Reverted it locally and it fixes it, so marking it as a regression

  6. johnmlee101 commented on Nov 10, 2023

    @johnmlee101
    Contributor

    Revert PR #31214 will need to be CPd

  7. johnmlee101 commented on Nov 10, 2023

    @johnmlee101
    Contributor

    fixed since the revert

  8. johnmlee101 commented on Nov 10, 2023

    @johnmlee101
    Contributor
    Screen.Recording.2023-11-10.at.5.18.58.PM.mov
  9. 3 remaining items

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Nov 14, 2023
  11. changed the title [-]Workspace - Start over page is not shown when user quits bank account setup and revisits it[/-] [+][HOLD for payment 2023-11-21] Workspace - Start over page is not shown when user quits bank account setup and revisits it[/+] on Nov 14, 2023
  12. melvin-bot commented on Nov 14, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Nov 14, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.98-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-11-21. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR
  14. changed the title [-][HOLD for payment 2023-11-21] Workspace - Start over page is not shown when user quits bank account setup and revisits it[/-] [+][HOLD for payment 2023-11-22] [HOLD for payment 2023-11-21] Workspace - Start over page is not shown when user quits bank account setup and revisits it[/+] on Nov 15, 2023
  15. melvin-bot commented on Nov 15, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.99-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-11-22. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions