Repository navigation
[C+ Checklist Needs Completion] [$500] Web - The app is freezing after switching tabs, and the performance of the tab navigator seems to be quite poor #31190
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.3.98.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @situchan
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1699629011502749?thread_ts=1699456424.016869&cid=C01GTK53T8Q
Action Performed:
- Go to staging.new.expensify.com
- Tab on Fab menu
- Select Request Money
- Navigate through the tabs
Expected Result:
The app is not freezing after switching tabs, and the performance of the tab navigator should be good
Actual Result:
The app is freezing after switching tabs, and the performance of the tab navigator seems to be quite poor
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
performance.mov
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01c6d30dd934f349b1
- Upwork Job ID: 1723032823278329856
- Last Price Increase: 2023-11-10
Metadata
Metadata
Labels
Type
Projects
- Status
Activity
OSBotify commentedon Nov 10, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Nov 10, 2023
Triggered auto assignment to @stitesExpensify (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.kbecciv commentedon Nov 10, 2023
Removing Deploy blocker per the comment https://expensify.slack.com/archives/C01GTK53T8Q/p1699637937484459?thread_ts=1699456424.016869&cid=C01GTK53T8Q
[-]Web - The app is freezing after switching tabs, and the performance of the tab navigator seems to be quite poor[/-][+][$500] Web - The app is freezing after switching tabs, and the performance of the tab navigator seems to be quite poor[/+]melvin-bot commentedon Nov 10, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01c6d30dd934f349b1
113 remaining items
mananjadhav commentedon Jan 29, 2024
Agreed with @shubham1206agra here.
I don't think we have any offending PR as this was a performance issue, and we disable the animation as a solution. Neither do I think we need a regression test for this one.
mountiny commentedon Jan 29, 2024
@mananjadhav @shubham1206agra I can see you both have reviewed the PR. I agree there was no regression, but I feel like you should divide the reward of $500 in this case, its not clear to me now why both c+ were needed
mananjadhav commentedon Jan 29, 2024
@mountiny More info here on why @shubham1206agra got involved and where we committed for the partial payout.
I think $250 each is fine for me.
mountiny commentedon Jan 29, 2024
Thank you for the link, I agree $250 each sounds fair!
mananjadhav commentedon Jan 29, 2024
@greg-schroeder Can you add a payment summary comment for us to raise a request?
JmillsExpensify commentedon Jan 30, 2024
$250 payment approved based on this comment. That is sufficient.
greg-schroeder commentedon Jan 30, 2024
Sorry, yeah okay so the final breakdown was:
@mananjadhav $250
@shubham1206agra $250
shubham1206agra commentedon Feb 3, 2024
@greg-schroeder I didn't received any payment for the same.
greg-schroeder commentedon Feb 5, 2024
Sorry, this was confusing @shubham1206agra - paying you here: #35793
shubham1206agra commentedon Feb 5, 2024
@greg-schroeder Accepted offer.