Repository navigation
ReportScreen Reassure test Flakiness #31145
Description
Activity
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.Bug0 Triage Checklist (Main S/O)
- This "bug" occurs on a supported platform (ensure
Platformsin OP are ✅) - This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
- This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
- This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
- I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
- This "bug" occurs on a supported platform (ensure
cc @adhorodyski
@adhorodyski @OlimpiaZurek How is it looking with this one, do you have any ETA for fix?
Hey @mountiny I'll look into it today. We don't have a specific ETA for this as we need to find the root cause first.
26 remaining items
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
- [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@OlimpiaZurek] Determine if we should create a regression test for this bug.
- [@OlimpiaZurek] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Made more progress seems like we got another PR in draft
Still working through this one.
- changed the title
[-][HOLD for payment 2023-12-06] [HOLD for payment 2023-12-04] ReportScreen Reassure test Flakiness [/-][+]ReportScreen Reassure test Flakiness [/+]on Dec 13, 2023 Last PR was merged for this! Seems like its working well now! Great job @OlimpiaZurek!
Not sure if there is anyone external to pay here so I am going to close this one!
Metadata
Metadata
Assignees
Labels
Type
Projects
- Status
Problem
As we roll out more Reassure based performance test, we are facing some flakiness in their outpust where they provide false positives. More context here https://expensify.slack.com/archives/C03UK30EA1Z/p1699546341608409?thread_ts=1699521471.426869&cid=C03UK30EA1Z
This is a problem as flakiness in these tests undermines its entire purpose, its not clear as of now what exactly is the root cause of the flaky tests here.
Solution
Identify the root cause of the flakiness and update the reassure test suite to get rid it of, since we measure the count of re-renders, this should not be happening with reassure so most likely this is an error on our side