[HOLD for payment 2023-11-21] [HOLD for payment 2023-11-17] Chat - Concierge Avatar is not centered

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.97.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to ND
2. Log in with any account
3. Select Concierge
4. Click on avatar

Expected Result:

Avatars is centered

Actual Result:

Avatars is not centered

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6269292_1699481763554.Recording__5288.mp4

Production

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[ishpaul777]

Proposal

Problem

Avatars is not centered

Root Cause

We didnt added alignItems: 'center', in attachmentCarouselContainer causing this issue.
offending PR- #30995

Changes

Add alignItems: 'center' here or here.

[ZhenjaHorbach]

regression this PR #30995

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - Avatars is not centered

What is the root cause of that problem?

We center the image vertically only

What changes do you think we should make in order to solve the problem?

we can update styles and add alignItems:'center' here

App/src/components/AttachmentModal.js

Line 449 in 01759d1

<View style={[styles.flex1, styles.attachmentCarouselContainer]}>

We don't need to add styles to attachmentCarouselContainer as this will break the carousel as in the first proposition

https://github.com/Expensify/App/blob/main/src/styles/styles.ts#L2520-L2526

What alternative solutions did you explore? (Optional)

NA

[ZhenjaHorbach]

@ishpaul777
Please add a comment that your second option was added after my explanations)