[HOLD for Payment][$500] Inconsistency of redirection after creating IOU and task

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.95.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1699054252287299

Action Performed:

1. Log in to ND
2. Create a Request money
3. Redirected to the DM
4. Create a task
5. Observe

Expected Result:

After creating IOU or task should be redirected to DM

Actual Result:

After creating task redirected to task itself

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.197.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016c50b7a867fe5efd
• Upwork Job ID: 1720787853214482432
• Last Price Increase: 2023-11-11
• Automatic offers:
• s-alves10 | Contributor | 27643579

Issue Owner

Current Issue Owner: @kevinksullivan

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016c50b7a867fe5efd

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Task creation redirects to the task report. Should redirect to the DM chat

What is the root cause of that problem?

We're redirecting to the task report after creating a task as you can see

App/src/libs/actions/Task.js

Line 216 in 7bd51eb

Navigation.dismissModal(optimisticTaskReport.reportID);

This is the root cause

What changes do you think we should make in order to solve the problem?

When creating a task, we have shareDestination and assignee.
I think it's reasonable to redirect to the shareDestination, not to DM chat

Updating

App/src/libs/actions/Task.js

Line 216 in 7bd51eb

Navigation.dismissModal(optimisticTaskReport.reportID);

to

    Navigation.dismissModal(parentReportID);

would redirect user to share destination

Result

30883.mp4

What alternative solutions did you explore? (Optional)

In the case we still want to redirect to the DM, we can update the above code to

    Navigation.dismissModal(assigneeChatReportID || parentReportID);

[PiyushChandra17]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistency of redirection after creating IOU and task

What is the root cause of that problem?

We are using optimisticTaskReport.reportID here,

App/src/libs/actions/Task.js

Line 216 in 7bd51eb

Navigation.dismissModal(optimisticTaskReport.reportID);

This is resulting to redirection to Task report instead of chat, perhaps this is the root cause.

What changes do you think we should make in order to solve the problem?

We should use assigneeChatReportID instead of optimisticTaskReport.reportID.

We should update this,

App/src/libs/actions/Task.js

Line 216 in 7bd51eb

Navigation.dismissModal(optimisticTaskReport.reportID);

with this,

Navigation.dismissModal(assigneeChatReportID);

This will Navigate to the chat after IOU and creating a task.

What alternative solutions did you explore? (Optional)

NA

Result:

[PiyushChandra17]

@s-alves10 I think assigneeChatReportID should be the way to go as it redirects to DM. You can get the reference from here,

App/src/libs/actions/Task.js

Lines 43 to 47 in 7bd51eb

	* A task needs two things to be created - a title and a parent report
	* When you create a task report, there are a few things that happen:
	* A task report is created, along with a CreatedReportAction for that new task report
	* A reportAction indicating that a task was created is added to the parent report (share destination)
	* If you assign the task to someone, a reportAction is created in the chat between you and the assignee to inform them of the task

[eh2077]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistency of redirection after creating IOU and task

What is the root cause of that problem?

The root cause of this issue is that after creating task, we open the task report, see

App/src/libs/actions/Task.js

Line 216 in 846a4b7

Navigation.dismissModal(optimisticTaskReport.reportID);

What changes do you think we should make in order to solve the problem?

To redirect to chat room after creating task, we can change

App/src/libs/actions/Task.js

Line 216 in 846a4b7

Navigation.dismissModal(optimisticTaskReport.reportID);

to

    const parentReport = ReportUtils.getReport(parentReportID);
    if (ReportUtils.isChatRoom(parentReport)) { // We can also consider group chat as chat room if necessary
        // We want to redirect to the parent report if this task is going to be shared to a chat room.
        Navigation.dismissModal(parentReportID);
    } else {
        Navigation.dismissModal(optimisticTaskReport.reportID);
    }

See demo

0-web.mp4

What alternative solutions did you explore? (Optional)

N/A