Repository navigation
[HOLD #30668] [$500] Chat - Unpinned deleted tasks assigned by another user are shown above other pinned messages #30798
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.3.95-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
- Login with Account A on new Expensify and assign a task to Account B
- Cancel the task
- Login with Account B > find the Deleted task in the LHN
Tester login credential: gatantm+82@gmail.com gatantm+112@gmail.com - If you don't see it above the pinned messages, click on the [Deleted task] message again and eventually it displays above the pinned chats
Expected Result:
Unpinned messages appear under pinned chats on LHN
Actual Result:
In the new build the Assigned tasks from another account that were canceled appear above or between pinned messages when they were never pinned
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
2023-11-02_16-42-06.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01f5bd596fa8bc9e1a
- Upwork Job ID: 1721590933982339072
- Last Price Increase: 2023-11-06
- Automatic offers:
- s77rt | Reviewer | 27545058
Activity
melvin-bot commentedon Nov 2, 2023
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Nov 2, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Nov 2, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Nov 2, 2023
Triggered auto assignment to @AndrewGable (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.kbecciv commentedon Nov 2, 2023
@Christinadobrzyn Can you create a task and assign it to user B using the 'share somewhere' option?
Christinadobrzyn commentedon Nov 2, 2023
I can reproduce with the steps in the OP. @kbecciv Should I also test the share somewhere option for this?
Christinadobrzyn commentedon Nov 2, 2023
90 remaining items
DylanDylann commentedon Dec 13, 2023
@Christinadobrzyn @s77rt This PR is merged. Let's remove hold
DylanDylann commentedon Dec 13, 2023
After re-check on the latest main, I see that after canceling the task the GRB still displays
bug.mp4
From my viewpoint, I think the GRB should disappear immediately after canceling the task
So that I post this proposal to fix this bug
Proposal
Please re-state the problem that we are trying to solve in this issue.
After canceling the task the GRB still displays on LHN
What is the root cause of that problem?
After canceling the task the GRB still displays on LHN, The pusher return taskReport.isDeletedParentAction === true . But we don't add this field in this function
App/src/libs/SidebarUtils.ts
Line 232 in 7f7cfb3
What changes do you think we should make in order to solve the problem?
in this function
App/src/libs/SidebarUtils.ts
Line 232 in 7f7cfb3
we should return
isDeletedParentActionWe also need to do the same thing in the chat report selector here
App/src/pages/home/sidebar/SidebarLinksData.js
Line 170 in 7f7cfb3
should add
What alternative solutions did you explore? (Optional)
NA
Result
sol.mp4
s77rt commentedon Dec 13, 2023
@DylanDylann This issue does not have
Help Wantedlabel. @waterim is already assigned to work on this issues77rt commentedon Dec 13, 2023
@Christinadobrzyn Please lift the hold since #32140 is merged now
s77rt commentedon Dec 13, 2023
@waterim Please check this issue once you get a chance
waterim commentedon Dec 14, 2023
@s77rt I can see that the issue here is "Unpinned deleted tasks assigned by another user are shown above other pinned messages", but this one was fixed and as I understand we want to fix GBR for deleted task as well here, right?
DylanDylann commentedon Dec 14, 2023
@s77rt @Christinadobrzyn Should we create a new issue for the bug that is mentioned here ? I think It also be a critical bug
waterim commentedon Dec 14, 2023
@s77rt After my check I agree with @DylanDylann solution, we are just not setting in time the data regarding "isDeletedParentAction" when pusher sends it to us. I can create a PR for that
s77rt commentedon Dec 15, 2023
Since this is another bug I think it would be fair to create another issue for it.
s77rt commentedon Dec 15, 2023
For this one I think we can just close it.
DylanDylann commentedon Dec 15, 2023
@Christinadobrzyn @lanitochka17 Could you help to create a new issue for this one. It is so similar this issue and it is critical bug
Action Performed:
Same as this issue
Expected Result:
The deleted task report should not appear between GRB reports
Actual Result:
The task report still appears between GRB reports and GRB appear in the deleted task report
Video
bug.mp4
cc @s77rt
Christinadobrzyn commentedon Dec 22, 2023
So sorry for the delay @DylanDylann I created the new issue here- #33477
should we close this one or work on them together?
s77rt commentedon Dec 22, 2023
@Christinadobrzyn This can be closed