Repository navigation
[HOLD for payment 2023-12-08] Incorrect month is opening when tapping Oct2023 statement in OldDot app #30743
Description
Activity
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.Bug0 Triage Checklist (Main S/O)
- This "bug" occurs on a supported platform (ensure
Platformsin OP are ✅) - This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
- This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
- This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
- I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
- This "bug" occurs on a supported platform (ensure
I'm not sure if this can be external so going to apply internal for now.
Job added to Upwork: https://www.upwork.com/jobs/~01f250a418a4564fbf
Triggered auto assignment to Contributor Plus for review of internal employee PR - @mananjadhav (
Internal)@mananjadhav, @Christinadobrzyn Whoops! This issue is 2 days overdue. Let's get this updated quick!
hey @mananjadhav can this be external? Let me know your thoughts!
@Christinadobrzyn Catching up, I'll test this by tomorrow.
Reacted by Christina Dobrzynski56 remaining items
Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.6-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-12-08. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
- External issue reporter
- Contributor that fixed the issue
- Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
- @mananjadhav does not require payment (Eligible for Manual Requests)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
- [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@mananjadhav] Determine if we should create a regression test for this bug.
- [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@muttmuure / @Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
🎉
Reacted by Christina Dobrzynskiprepping for payment!
Payouts due:
Issue Reporter: NA
Contributor: NA
Contributor+: $500 @mananjadhav (paid through NewExpensify)Eligible for 50% #urgency bonus? N
Upwork job is NA
@mananjadhav do we need a regression test for this?
I don't think we do, but I would still want to confirm with @hayata-suenaga. This was fixed internally and I reviewed the code.
I also don't think we need a regression test
Reacted by MananAwesome! I think this can be closed out but @mananjadhav please make sure to request payment through NewExpensify.
$500 payment approved for @mananjadhav based on this summary.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number:
Reproducible in staging?: needs reproduction (don't have statement)
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @cead22
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1698869124487529
Action Performed:
Expected Result:
Statement should open in NewDot with correct header and translation. Link shou
Actual Result:
Noviembre 2023 StatementEstado de cuenta de Octubre 2023Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
Upwork Automation - Do Not Edit