Repository navigation
[HOLD for payment 2023-12-15] [$500] IOS - A spinner appears in the chat when a message is posted #30729
Description
Activity
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
Triggered auto assignment to @aldo-expensify (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.Can't reproduce in Web, I'm trying to setup my env to run IOS
Reacted by Alex BeamanI'm not being able to reproduce this.
This is the code that renders that spinner at the bottom:
(thanks @Beamanator)App/src/pages/home/report/ListBoundaryLoader/ListBoundaryLoader.js
Lines 59 to 64 in 30da921
This can only happen when
typeis HEADER, so the only usage of theListBoundaryLoaderwe should look at is this one:Asking for help reproducing here: https://expensify.slack.com/archives/C01GTK53T8Q/p1698867709638349
I was able to reproduce more consistently with @s-alves10 's help. I'll try to reproduce in production to see if this is a real deploy blocker or not
I think this would be reproducible in production as well
I think this would be reproducible in production as well
I had the same feeling, and I just confirmed it.
Removing deploy blocker, reproduced in production:
Screen.Recording.2023-11-01.at.1.48.23.PM.mov
My guess is that this may have been caused by this PR: #26166 that introduced the bidirectional pagination for comments
Reacted by Alex Beaman64 remaining items
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.9-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-12-15. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
- External issue reporter
- Contributor that fixed the issue
- Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
- @abdulrahuman5196 requires payment automatic offer (Reviewer)
- @perunt does not require payment (Contractor)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
- [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@abdulrahuman5196] Determine if we should create a regression test for this bug.
- [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@conorpendergrast] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
@conorpendergrast, @abdulrahuman5196, @roryabraham, @perunt Whoops! This issue is 2 days overdue. Let's get this updated quick!
Payouts due:
Issue Reporter: N/A - @mountiny
Contributor: N/A (contractor) @perunt- Contributor+: $500 @abdulrahuman5196 - contract
Upwork job is here.
@abdulrahuman5196 just the C+ checklist to do now, thanks!
The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:Seems to related to code changes introduced as part of comment linking.
Determine if we should create a regression test for this bug.
Yes. If not already present.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- Open a chat and check the bottom loader, you shouldn't see it.
- Scroll to the top and bottom to check if it appears.
- Send messages.
- No bottom loader should appear as you send messages
Thank you for processing. @conorpendergrast I have also added the checklist.
@conorpendergrast, @abdulrahuman5196, @roryabraham, @perunt Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Regression test created: https://github.com/Expensify/Expensify/issues/353947
Thanks all!
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.3.94.1
Reproducible in staging?: YES
Reproducible in production?: NO
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mountiny
Slack conversation:
Action Performed:
Expected Result:
A spinner doesn't appear in the chat when a message is posted
Actual Result:
A spinner appears in the chat when a message is posted
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
RPReplay_Final1698857268.mov
RPReplay_Final1698860649.MP4
View all open jobs on GitHub
Upwork Automation - Do Not Edit