[HOLD for payment 2023-12-07] [$500] IOU - Inconsistency in Scan split bill IOU preview for creator&Participant

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.94.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Go to https://staging.new.expensify.com/
Tap fab-Request Money
Tap Scan
Upload a picture by taking photo
Split with any 2 users
Tap add to Split
Tap split
Tap scan request created
Enter amount, description and merchant field
Tap split
Note: The description in OIU is displayed
Log in with any user with whom you've split the bill
Open IOU
Note: The Merchant in OIU is displayed

Expected Result:

There should not be inconsistency in IOU preview displayed for scan request creator and participant.

Actual Result:

For user who made scan request and split bill with 2 users, description details entered is shown in IOU preview. But for participant of split bill, merchant details entered is shown in IOU preview. There is inconsistency in IOU preview displayed for scan request creator and participant.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen_Recording_20231107_120329_Chrome.mp4

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01890520fc54e620e1
Upwork Job ID: 1719686303480401920
Last Price Increase: 2023-11-01
Automatic offers:

cubuspl42 | Reviewer | 27750967
dukenv0307 | Contributor | 27750969

@miljakljajic

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Job added to Upwork: https://www.upwork.com/jobs/~01890520fc54e620e1

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

Split bill preview display description while IOU Preview display merchant

What is the root cause of that problem?

We only show merchant if the request preview is not split bill

App/src/components/ReportActionItem/MoneyRequestPreview.js

Lines 172 to 175 in c8e7ee5

    
           const shouldShowMerchant = 
        
               !_.isEmpty(requestMerchant) && !props.isBillSplit && requestMerchant !== CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT && requestMerchant !== CONST.TRANSACTION.DEFAULT_MERCHANT; 
        
           const shouldShowDescription = !_.isEmpty(description) && !shouldShowMerchant;

What changes do you think we should make in order to solve the problem?

I think we should also show merchant for split bill by removing the condition !props.isBillSplit and and change the marigin style of merchant text if it's split bill

App/src/components/ReportActionItem/MoneyRequestPreview.js

Line 173 in c8e7ee5

    
           !_.isEmpty(requestMerchant) && !props.isBillSplit && requestMerchant !== CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT && requestMerchant !== CONST.TRANSACTION.DEFAULT_MERCHANT;

Or Update the condition here to

{shouldShowDescription || (shouldShowMerchant && props.isBillSplit) && <Text style={[styles.colorMuted]}>{description || requestMerchant}</Text>}

And here to

shouldShowMerchant && !props.isBillSplit

App/src/components/ReportActionItem/MoneyRequestPreview.js

Line 318 in c8e7ee5

{shouldShowMerchant && (

App/src/components/ReportActionItem/MoneyRequestPreview.js

Line 328 in c8e7ee5

    
           {shouldShowDescription && <Text style={[styles.colorMuted]}>{description}</Text>}

What alternative solutions did you explore? (Optional)

We can prioritize description over merchant

@cubuspl42 any thoughts on the above proposal?

@cubuspl42 The PR is ready for review.

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Reviewing label has been removed, please complete the "BugZero Checklist".

@dukenv0307

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.5-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Show merchant for split bill #31604

If no regressions arise, payment will be issued on 2023-12-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@cubuspl42 requires payment offer (Reviewer)
@dukenv0307 requires payment offer (Contributor)

@miljakljajic

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@cubuspl42] The PR that introduced the bug has been identified. Link to the PR:
[@cubuspl42] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@cubuspl42] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@cubuspl42] Determine if we should create a regression test for this bug.
[@cubuspl42] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Both contracts paid and ended. Thank you for your work!

@miljakljajic

@miljakljajic Did we reduce the pay? Since it caused a deploy blocker and PR had to be reverted.

@dukenv0307

Ah, I had no idea we needed to reduce the pay. I'll request a partial refund from @dukenv0307 and @cubuspl42

@miljakljajic

@miljakljajic Is it possible on Upwork?

Navigation Menu

Repository navigation

[HOLD for payment 2023-12-07] [$500] IOU - Inconsistency in Scan split bill IOU preview for creator&Participant #30680

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

39 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const shouldShowMerchant =
	!_.isEmpty(requestMerchant) && !props.isBillSplit && requestMerchant !== CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT && requestMerchant !== CONST.TRANSACTION.DEFAULT_MERCHANT;
	const shouldShowDescription = !_.isEmpty(description) && !shouldShowMerchant;

[HOLD for payment 2023-12-07] [$500] IOU - Inconsistency in Scan split bill IOU preview for creator&Participant #30680

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Nov 1, 2023

melvin-bot commented on Nov 1, 2023

melvin-bot commented on Nov 1, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Nov 1, 2023

dukenv0307 commented on Nov 1, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

miljakljajic commented on Nov 6, 2023

39 remaining items

dukenv0307 commented on Nov 21, 2023

melvin-bot commented on Nov 29, 2023

melvin-bot commented on Nov 30, 2023

melvin-bot commented on Nov 30, 2023

melvin-bot commented on Nov 30, 2023

miljakljajic commented on Dec 7, 2023

pecanoro commented on Dec 7, 2023

miljakljajic commented on Dec 7, 2023

jakub-trzebiatowski commented on Dec 12, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions