[HOLD for payment 2023-12-04] [HOLD for payment 2023-11-29] [$125] [Form Provider Refactor] BankAccountManualStep

@kowczarz

Coming from #25397 (comment), we created a new Form provider that works with functional components and we need to refactor all usages of the old Form component.

This issue is specific to refactoring src/pages/ReimbursementAccount/BankAccountManualStep.js

cc @kowczarz @cdOut

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01d24f22fcaf598dd6
Upwork Job ID: 1716963666355748865
Last Price Increase: 2023-10-26

@greg-schroeder

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Job added to Upwork: https://www.upwork.com/jobs/~01d24f22fcaf598dd6

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@mananjadhav

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mananjadhav (Internal)

@cdOut

@cdOut will you be working on this issue too?

@luacmartins

@luacmartins yes, I will be working on this issue.

@luacmartins

@luacmartins @greg-schroeder I didn't realize until today that the price was set to $125. Can we please up the price to normal payout? It wasn't a drop-in replacement, had to review the draftValues logic as well.

@mananjadhav

@mananjadhav thanks for raising this. I understand that not issues are made equal and this one involved more than just a simple drop-in replacement, but we decided to price these at $125 regardless of the level of involvement needed. I hope that you understand that.

Okay thanks for clarifying.

@mananjadhav

$125 payment approved for @mananjadhav based on this comment.

@JmillsExpensify

@JmillsExpensify it seems like we processed payment already. Are we good to close?

Navigation Menu

Repository navigation

[HOLD for payment 2023-12-04] [HOLD for payment 2023-11-29] [$125] [Form Provider Refactor] BankAccountManualStep #30316

Bug0 Triage Checklist (Main S/O)

33 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-12-04] [HOLD for payment 2023-11-29] [$125] [Form Provider Refactor] BankAccountManualStep #30316

Description

Activity

melvin-bot commented on Oct 24, 2023

melvin-bot commented on Oct 24, 2023

melvin-bot commented on Oct 24, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Oct 24, 2023

luacmartins commented on Oct 25, 2023

cdOut commented on Oct 26, 2023

33 remaining items

mananjadhav commented on Nov 29, 2023

luacmartins commented on Nov 30, 2023

mananjadhav commented on Nov 30, 2023

JmillsExpensify commented on Dec 1, 2023

luacmartins commented on Dec 4, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions