[$125] [Form Provider Refactor] ACHContractStep

@kowczarz

Coming from #25397 (comment), we created a new Form provider that works with functional components and we need to refactor all usages of the old Form component.

This issue is specific to refactoring src/pages/ReimbursementAccount/ACHContractStep.js

cc @kowczarz @cdOut

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01cc4521b1d4b152cc
Upwork Job ID: 1716963452301692928
Last Price Increase: 2023-10-26

Issue Owner

Current Issue Owner: @cdOut

Job added to Upwork: https://www.upwork.com/jobs/~01cc4521b1d4b152cc

@twisterdotcom

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@ntdiary

Triggered auto assignment to Contributor Plus for review of internal employee PR - @ntdiary (Internal)

@cdOut

@cdOut will you be working on this issue too?

@luacmartins

@luacmartins yes, I will be working on this issue.

@cdOut

Any update here @cdOut?

Ah wait, I see: #30665 (comment)

@twisterdotcom

Ah wait, I see: #30665 (comment)

@twisterdotcom, it looks like the refactoring has also been completed in another PR #30568. I noticed they modified the same code.

This issue was fixed in #30568, both flows were using a specific subform that had to be updated, so I had to update all the forms using it. This component is already refactored into FormProvider and is currently merged on main.

Looks like this caused some deployblockers: #30568 (comment). I don't think we can call this done yet.

@cdOut

Can we close this out now actually @cdOut and @luacmartins?

Yes, this is already merged and on main, as far as I'm concerned the deploy blockers were regarding different parts of form migration.

Yea, we're good to close this one. Thanks everyone!

Navigation Menu

Repository navigation

[$125] [Form Provider Refactor] ACHContractStep #30314

24 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[$125] [Form Provider Refactor] ACHContractStep #30314

Description

Activity

melvin-bot commented on Oct 24, 2023

melvin-bot commented on Oct 24, 2023

melvin-bot commented on Oct 24, 2023

melvin-bot commented on Oct 24, 2023

luacmartins commented on Oct 25, 2023

cdOut commented on Oct 26, 2023

24 remaining items

twisterdotcom commented on Nov 16, 2023

twisterdotcom commented on Nov 16, 2023

ntdiary commented on Nov 17, 2023

cdOut commented on Nov 21, 2023

twisterdotcom commented on Nov 21, 2023

twisterdotcom commented on Dec 12, 2023

cdOut commented on Dec 12, 2023

luacmartins commented on Dec 12, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions