Repository navigation
[HOLD for payment 2023-12-08] [HOLD for payment 2023-12-06] [$125] [Form Provider Refactor] IdologyQuestions #30313
Description
Activity
Job added to Upwork: https://www.upwork.com/jobs/~010e0b2b5e81ad4761
Triggered auto assignment to @sonialiap (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.Bug0 Triage Checklist (Main S/O)
- This "bug" occurs on a supported platform (ensure
Platformsin OP are ✅) - This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
- This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
- This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
- I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
- This "bug" occurs on a supported platform (ensure
Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (
Internal)@cdOut will you be working on this issue too?
@luacmartins yes, I will be working on this issue.
52 remaining items
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
- [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@s77rt] Determine if we should create a regression test for this bug.
- [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
- The PR that introduced the bug has been identified: n/a Not a bug but a code refactor
- The offending PR has been commented on: n/a
- A discussion in #expensify-bugs has been started: n/a
- Determine if we should create a regression test for this bug: n/a
Reacted by Sonia Liapounova@s77rt $125 - offer sent
Accepted! Please note that the payment due here is $62.5 (since there was a regression)
Coming from #25397 (comment), we created a new Form provider that works with functional components and we need to refactor all usages of the old Form component.
This issue is specific to refactoring
src/pages/EnablePayments/IdologyQuestions.jscc @kowczarz @cdOut
Upwork Automation - Do Not Edit