Skip to content

[HOLD for payment 2023-11-09] [$125] [Form Provider Refactor] MoneyRequestDescriptionPage #30305

Closed
Closed
[HOLD for payment 2023-11-09] [$125] [Form Provider Refactor] MoneyRequestDescriptionPage#30305
Assignees
luacmartinsfedirjhjoekaufmanexpensifycdOut
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Description

@luacmartins
luacmartins
opened on Oct 24, 2023

Coming from #25397 (comment), we created a new Form provider that works with functional components and we need to refactor all usages of the old Form component.

This issue is specific to refactoring src/pages/iou/MoneyRequestDescriptionPage.js

cc @kowczarz @cdOut

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019c43ec410d30c483
  • Upwork Job ID: 1716961630217142272
  • Last Price Increase: 2023-10-25

Activity

  1. luacmartins
    added
    DailyKSv2
    InternalRequires API changes or must be handled by Expensify staff
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 24, 2023
  2. luacmartins
    self-assigned this
    on Oct 24, 2023

  3. melvin-bot commented on Oct 24, 2023

    @melvin-bot
    melvin-botbot
    on Oct 24, 2023

    Job added to Upwork: https://www.upwork.com/jobs/~019c43ec410d30c483

  4. melvin-bot commented on Oct 24, 2023

    @melvin-bot
    melvin-botbot
    on Oct 24, 2023

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  5. melvin-bot
    assigned
    joekaufmanexpensify
    on Oct 24, 2023

  6. melvin-bot commented on Oct 24, 2023

    @melvin-bot
    melvin-botbot
    on Oct 24, 2023

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  7. melvin-bot
    assigned
    fedirjh
    on Oct 24, 2023

  8. melvin-bot commented on Oct 24, 2023

    @melvin-bot
    melvin-botbot
    on Oct 24, 2023

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @fedirjh (Internal)

  9. cdOut commented on Oct 25, 2023

    @cdOut
    cdOut
    on Oct 25, 2023
    Contributor

    Hello, I'm Tymoteusz Kałuzieński from Software Mansion, the expert agency, and I would like to work on this task.

  10. luacmartins
    assigned
    cdOut
    on Oct 25, 2023
  11. luacmartins
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    InternalRequires API changes or must be handled by Expensify staff
    on Oct 25, 2023
  12. melvin-bot
    changed the title [-][Form Provider Refactor] MoneyRequestDescriptionPage[/-] [+][$500] [Form Provider Refactor] MoneyRequestDescriptionPage[/+] on Oct 25, 2023

  13. 20 remaining items

  14. melvin-bot commented on Nov 2, 2023

    @melvin-bot
    melvin-botbot
    on Nov 2, 2023 – with Melvin Bot · Hidden as off-topic

  15. joekaufmanexpensify commented on Nov 6, 2023

    @joekaufmanexpensify
    joekaufmanexpensify
    on Nov 6, 2023
    Contributor

    @fedirjh could you take care of BZ checklist this week so we can prep to issue payments? TY!

  16. fedirjh commented on Nov 6, 2023

    @fedirjh
    fedirjh
    on Nov 6, 2023
    Contributor

    @joekaufmanexpensify I don't think we need any checklist for this issue. We just did a refactor, there were no bug fixes involved. It should have been labeled as an improvement rather than a bug fix.

  17. joekaufmanexpensify commented on Nov 6, 2023

    @joekaufmanexpensify
    joekaufmanexpensify
    on Nov 6, 2023
    Contributor

    Ah, okay cool. Makes sense. We'll issue payment on the 9th then!

  18. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Nov 8, 2023

  19. joekaufmanexpensify commented on Nov 8, 2023

    @joekaufmanexpensify
    joekaufmanexpensify
    on Nov 8, 2023
    Contributor

    @fedirjh offer sent for $125!

  20. joekaufmanexpensify commented on Nov 9, 2023

    @joekaufmanexpensify
    joekaufmanexpensify
    on Nov 9, 2023
    Contributor

    @fedirjh $125 sent and contract ended!

  21. joekaufmanexpensify commented on Nov 9, 2023

    @joekaufmanexpensify
    joekaufmanexpensify
    on Nov 9, 2023
    Contributor

    All set. Thanks everyone!

  22. joekaufmanexpensify
    closed this as completedon Nov 9, 2023
  23. melvin-bot
    added
    ReviewingHas a PR in review
    WeeklyKSv2
    and removed
    DailyKSv2
    on Jan 18, 2024
  24. melvin-bot
    added
    WeeklyKSv2
    and removed
    WeeklyKSv2
    on Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions