[HOLD for payment 2023-11-01] Stop saving receipt in IOU action

Problem

We're unnecessarily saving the receipt object in the IOU reportAction object

Why is this important

Keeps data format consistent with what's expected

Solution

Stop saving the receipt in the IOU action

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~013916d2c5796f424f
Upwork Job ID: 1715425653755682816
Last Price Increase: 2023-10-20

@garrettmknight

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Job added to Upwork: https://www.upwork.com/jobs/~013916d2c5796f424f

@akinwale

Triggered auto assignment to Contributor Plus for review of internal employee PR - @akinwale (Internal)

Reviewing label has been removed, please complete the "BugZero Checklist".

@akinwale

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.90-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[No QA] Remove receipt from IOU report action #28424

If no regressions arise, payment will be issued on 2023-11-01. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@akinwale requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@akinwale

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@akinwale] The PR that introduced the bug has been identified. Link to the PR:
[@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@akinwale] Determine if we should create a regression test for this bug.
[@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@akinwale

@akinwale offer sent

@akinwale

@akinwale offer sent

Accepted. Thanks!

@garrettmknight

@garrettmknight Do I need to do anything else here?

Nope - just had to pay you. Done!

Navigation Menu

Repository navigation

[HOLD for payment 2023-11-01] Stop saving receipt in IOU action #30096

Problem

Why is this important

Solution

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-11-01] Stop saving receipt in IOU action #30096

Description

Problem

Why is this important

Solution

Activity

melvin-bot commented on Oct 20, 2023

melvin-bot commented on Oct 20, 2023

melvin-bot commented on Oct 20, 2023

melvin-bot commented on Oct 20, 2023

melvin-bot commented on Oct 25, 2023

melvin-bot commented on Oct 25, 2023

melvin-bot commented on Oct 25, 2023

garrettmknight commented on Nov 1, 2023

akinwale commented on Nov 1, 2023

akinwale commented on Nov 3, 2023

garrettmknight commented on Nov 3, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions