[HOLD for payment 2023-11-06] [$500] [Form Provider Refactor] PrivateNotesEditPage

@kowczarz

Coming from #25397 (comment), we created a new Form provider that works with functional components and we need to refactor all usages of the old Form component.

This issue is specific to refactoring src/pages/PrivateNotes/PrivateNotesEditPage.js

cc @kowczarz @cdOut

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~019146cfb545848865
Upwork Job ID: 1715043040782385152
Last Price Increase: 2023-10-20

Job added to Upwork: https://www.upwork.com/jobs/~019146cfb545848865

@peterdbarkerUK

Triggered auto assignment to @peterdbarkerUK (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@robertKozik

Triggered auto assignment to Contributor Plus for review of internal employee PR - @robertKozik (Internal)

SWM will work on this, no need for a proposal

Hello! I'm Kamil Owczarz from Software Mansion, the expert agency and I would like to work on this task.

Reviewing label has been removed, please complete the "BugZero Checklist".

@robertKozik

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.92-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[Form Provider Refactor] PrivateNotesEditPage #30071

If no regressions arise, payment will be issued on 2023-11-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@robertKozik does not require payment (Contractor)
@kowczarz does not require payment (Contractor)

@robertKozik

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@robertKozik] The PR that introduced the bug has been identified. Link to the PR:
[@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@robertKozik] Determine if we should create a regression test for this bug.
[@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@peterdbarkerUK] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

No regression tests or payments needed, I'm officially a full-blown bureaucrat. I'm sure my grandparents would be proud of me.

Thanks for the work here guys ;)

Navigation Menu

Repository navigation

[HOLD for payment 2023-11-06] [$500] [Form Provider Refactor] PrivateNotesEditPage #30004

17 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-11-06] [$500] [Form Provider Refactor] PrivateNotesEditPage #30004

Description

Activity

melvin-bot commented on Oct 19, 2023

melvin-bot commented on Oct 19, 2023

melvin-bot commented on Oct 19, 2023

melvin-bot commented on Oct 19, 2023

luacmartins commented on Oct 19, 2023

kowczarz commented on Oct 20, 2023

17 remaining items

melvin-bot commented on Oct 30, 2023

melvin-bot commented on Oct 30, 2023

melvin-bot commented on Oct 30, 2023

peterdbarkerUK commented on Nov 7, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions