Skip to content

[HOLD for payment 2023-11-06] [$500] [Form Provider Refactor] TaskDescriptionPage #29998

Closed

Description

@luacmartins

Coming from #25397 (comment), we created a new Form provider that works with functional components and we need to refactor all usages of the old Form component.

This issue is specific to refactoring src/pages/tasks/TaskDescriptionPage.js

cc @kowczarz @cdOut

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019cc2c1cbf43ec7af
  • Upwork Job ID: 1715041841053011968
  • Last Price Increase: 2023-10-20

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 19, 2023
  2. self-assigned this
    on Oct 19, 2023
  3. melvin-bot commented on Oct 19, 2023

    @melvin-bot
  4. melvin-bot commented on Oct 19, 2023

    @melvin-bot

    Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  5. melvin-bot commented on Oct 19, 2023

    @melvin-bot
  6. melvin-bot commented on Oct 19, 2023

    @melvin-bot

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @robertKozik (Internal)

  7. luacmartins commented on Oct 19, 2023

    @luacmartins
    ContributorAuthor

    SWM will work on this, no need for a proposal

  8. cdOut commented on Oct 20, 2023

    @cdOut
    Contributor

    Hello! I'm Tymoteusz Kałuzieński from Software Mansion, the expert agency and I would like to work on this task.

  9. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    InternalRequires API changes or must be handled by Expensify staff
    on Oct 20, 2023
  10. 18 remaining items

  11. MitchExpensify commented on Nov 1, 2023

    @MitchExpensify
    Contributor

    Do you think we should add a new regression test @robertKozik ?

  12. luacmartins commented on Nov 8, 2023

    @luacmartins
    ContributorAuthor

    Pending BZ checklist and payment

  13. MitchExpensify commented on Nov 9, 2023

    @MitchExpensify
    Contributor

    No payment is necessary here but I am still curious on whether we should add a new regression test @robertKozik 👀

  14. robertKozik commented on Nov 10, 2023

    @robertKozik
    Contributor

    Sorry 🙇🏼 I don't think we need regression test for it

    • [@robertKozik] The PR that introduced the bug has been identified. Link to the PR: N/A
    • [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
    • [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • [@robertKozik] Determine if we should create a regression test for this bug. I don't think we need regression test for it
    • [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A
  15. MitchExpensify commented on Nov 13, 2023

    @MitchExpensify
    Contributor

    All good! Thanks @robertKozik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions