Skip to content

[SMARTSCAN] [$500] MEDIUM: Scan - Workspace admin sees empty report when employee manually enters Scan request details #29828

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.85-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. [Employee} Create a scan request in the workspace chat
  3. [Employee] Manually enter amount and merchant
  4. [Admin] Click on the expense preview in the workspace chat with employee when the preview appears

Expected Result:

Workspace admin should be able to view the expense in expense report page

Actual Result:

Workspace admin is unable to view the expense in expense report page. Only the amount is seen in the report page. There is no expense preview that leads to expense details page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Bug6240983_1697571472403.20231018_025445.mp4
MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0100429f58a52793a1
  • Upwork Job ID: 1714385920798265344
  • Last Price Increase: 2023-11-07
Issue OwnerCurrent Issue Owner: @cristipaval

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 17, 2023
  2. melvin-bot commented on Oct 17, 2023

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. changed the title [-]Scan - Workspace admin sees empty report when employee manually enters Scan request details[/-] [+][$500] Scan - Workspace admin sees empty report when employee manually enters Scan request details[/+] on Oct 17, 2023
  4. melvin-bot commented on Oct 17, 2023

    @melvin-bot
  5. melvin-bot commented on Oct 17, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 17, 2023
  7. melvin-bot commented on Oct 17, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

  8. AmjedNazzal commented on Oct 19, 2023

    @AmjedNazzal
    Contributor

    Admin can't see it because receipt scan is in progress, a receipt that is still scanning is a whisper so only visible to the user who started it. once the scan completes or fails if the admin refreshes or leave chat and come back they would see the receipt and the changes.

  9. allroundexperts commented on Oct 19, 2023

    @allroundexperts
    Contributor

    @AmjedNazzal I think it should update without needing to Refresh.

  10. sakluger commented on Oct 23, 2023

    @sakluger
    Contributor

    I agree that it should update. Even though the receipt is still scanning, the user manually entered details, which takes priority over the scanned details.

  11. 82 remaining items

  12. added and removed on Nov 27, 2023
  13. sakluger commented on Nov 27, 2023

    @sakluger
    Contributor

    Switching to weekly since this is Internal but doesn't have an assigned engineer. It's in the "FIRE" section of the milestone, so an engineer should pick it up once they have time.

  14. self-assigned this
    on Nov 29, 2023
  15. Victor-Nyagudi commented on Dec 2, 2023

    @Victor-Nyagudi
    Contributor

    This issue also involves interrupting the receipt scanning albeit while splitting a bill in a workspace room. This time, an error is shown after the interruption.

    Not sure if it's related but just thought I'd mention it.

  16. melvin-bot commented on Dec 25, 2023

    @melvin-bot

    This issue has not been updated in over 15 days. @sakluger, @Gonals, @allroundexperts eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  17. moved this from Release 3: Card Experience to Release 2: Migration for All in [#whatsnext] Wave 05 - Deprecate Freeon Jan 5, 2024
  18. Gonals commented on Jan 11, 2024

    @Gonals
    Contributor

    This is fixed

  19. moved this from Release 3: Migration for All to Done in [#whatsnext] Wave 05 - Deprecate Freeon Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringInternalRequires API changes or must be handled by Expensify staffMonthlyKSv2ReviewingHas a PR in reviewSmartScanWave5-free-submitters

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions