Repository navigation
[HOLD for payment 2024-01-03] Comment doesn't update to the Merchant name in the split preview component after the receipt scan completes #29732
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.3.84-4
Reproducible in staging?: Yes
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: (internal ref) https://expensify.slack.com/archives/C02NZ2HGJAZ/p1697490579346919?thread_ts=1697488517.137999&cid=C02NZ2HGJAZ
Action Performed:
- Global create > Request money > scan a receipt
- Select 2 participants to split > add a description on the confirmation page > confirm
- Wait for receipt scanning to complete
- Observe the split preview component in the groupDM contains the comment
- Observe the iouReport preview component in each of the DM's between payer:participant contains the merchant
Expected Result:
When the receipt scanning completes, the split preview component should update with the merchant name
Actual Result:
When the receipt scanning completes, the split preview component remains as the description
Workaround:
N/A
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01c51bbff62b3a32f7
- Upwork Job ID: 1714065110591516672
- Last Price Increase: 2023-10-16
Activity
melvin-bot commentedon Oct 16, 2023
Current assignee @youssef-lr is eligible for the Engineering assigner, not assigning anyone new.
melvin-bot commentedon Oct 16, 2023
Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.
melvin-bot commentedon Oct 16, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01c51bbff62b3a32f7
melvin-bot commentedon Oct 16, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Oct 16, 2023
Triggered auto assignment to Contributor Plus for review of internal employee PR - @robertKozik (
Internal)trjExpensify commentedon Oct 16, 2023
👋 @youssef-lr keeping this one internal and assigned to us for the time being. Maybe the work with the empty merchant has caught this one, but logging it so we have it if not.
youssef-lr commentedon Oct 19, 2023
Working on this tomorrow.
35 remaining items
trjExpensify commentedon Jan 3, 2024
I think we're good to close this as @robertKozik payment will be handled elsewhere. Regression test for this should be covered in https://github.com/Expensify/Expensify/issues/356417 holistically.
aimane-chnaif commentedon Jan 3, 2024
@trjExpensify I was C+ reviewer in PR
trjExpensify commentedon Jan 3, 2024
Oh! Sorry, I thought that was the other one!
trjExpensify commentedon Jan 3, 2024
So @aimane-chnaif you're due $500 for the C+ review?
aimane-chnaif commentedon Jan 3, 2024
yes
trjExpensify commentedon Jan 3, 2024
Cool, offer sent.
trjExpensify commentedon Jan 5, 2024
Paid!