[HOLD for payment 2023-12-08] [$500] Distance - Prevent deleting receipt

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.84-6

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL: Applause - Internal Team

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

Go to staging.new.expensify.com
Go to + > Request money > Distance
Create a distance request to the workspace chat
Click on the distance request preview twice
Click on the receipt > Three-dot menu > Delete receipt > Delete
Click on Distance
Add a more stop and Save it

Expected Result:

The new distance is saved

New: You should not be able to remove the distance receipt in the first place

Actual Result:

The new distance is not saved. Clicking on Save does not save it and close the edit page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6239133_1697466370603.20231016_205452.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~019e0aeb0e907b54cf
Upwork Job ID: 1715165699664687104
Last Price Increase: 2023-11-22
Automatic offers:

dukenv0307 | Contributor | 27853396

@stephanieelliott

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Looks like receipt is required to edit distance request.

Backend is sending error saying that receipt is not found

I think expected result should be sorted out before proceeding: Should distance request be allowed to be edited if its receipt is deleted?

This looks like a backend issue
The backend returns 404 as below

Seems like a backend issue, I think ideally when receipt is not available during distance request update, backend should generate a new receipt based on newly selected waypoints.

Ok, thanks! Adding labels to assign an internal engineer for BE changes.

@danieldoglas

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Reviewing label has been removed, please complete the "BugZero Checklist".

@Santhosh-Sellavel

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.6-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Prevent deleting and replacing receipt in distance request #32092

If no regressions arise, payment will be issued on 2023-12-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@Santhosh-Sellavel does not require payment (Eligible for Manual Requests)
@dukenv0307 requires payment offer (Contributor)

@Santhosh-Sellavel

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
[@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@Santhosh-Sellavel] Determine if we should create a regression test for this bug.
[@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@dukenv0307

Summarizing payment on this issue:

Issue reporter: N/A
Contributor: $500 @dukenv0307 PAID via Upwork
Contributor+: $500, @Santhosh-Sellavel please request via NewDot!
Upwork job is here

@thienlnam

Regression Steps should be enough here because the behavior was intentional earlier when it was added. Let me know your thoughts @thienlnam

Steps

Create a distance request
After the request is created, go to the transaction thread report
Click on the receipt image
Click on the three-dot in the attachment modal
Verify that only the download option appears

@Santhosh-Sellavel

Issue for QA test here: https://github.com/Expensify/Expensify/issues/349090

All clear here, @Santhosh-Sellavel please request your payment via newdot!

Requested on ND

@Santhosh-Sellavel

$500 payment approved for @Santhosh-Sellavel based on this comment.

Navigation Menu

Repository navigation

[HOLD for payment 2023-12-08] [$500] Distance - Prevent deleting receipt #29684

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Bug0 Triage Checklist (Main S/O)

75 remaining items

Steps

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-12-08] [$500] Distance - Prevent deleting receipt #29684

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Oct 16, 2023

melvin-bot commented on Oct 16, 2023

Bug0 Triage Checklist (Main S/O)

alitoshmatov commented on Oct 16, 2023

dummy-1111 commented on Oct 16, 2023

hnkuanx commented on Oct 17, 2023

stephanieelliott commented on Oct 20, 2023

melvin-bot commented on Oct 20, 2023

75 remaining items

melvin-bot commented on Dec 1, 2023

melvin-bot commented on Dec 1, 2023

melvin-bot commented on Dec 1, 2023

stephanieelliott commented on Dec 8, 2023

Santhosh-Sellavel commented on Dec 10, 2023

Steps

stephanieelliott commented on Dec 13, 2023

Santhosh-Sellavel commented on Jan 10, 2024

JmillsExpensify commented on Jan 14, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions