[HOLD for payment 2023-11-09] [Wave 6: Categories] Design follow up to Tag and Category lists

@waterim

Here is an tracking issue to compile feedback and implement improved design for the category and tag list

@laurenreidexpensify

Triggered auto assignment to @laurenreidexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

I think something like this would be more ideal:

Each child/sub-category should get an additional 12px of left padding, and this padding is applied to the whole row so that the text has the same left edge
There should be 20px of space between each "block" with each block meaning the Search box, the current selection, the Recents block, and then the All block

cc @Expensify/design for thoughts if you have any!

For anything that takes more than two lines, we should just overflow with elipse is that right?

Also, just FYI, in case this wasn't known, this is how we show a sub-category when it has been selected and you re-enter the list. It's shown at the top with colons to indicate the full selection:

I like that - so show two lines worth of text and truncate after that? That should be plenty I think.

Reviewing label has been removed, please complete the "BugZero Checklist".

@rezkiy37

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.94-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Design follow up to Tag and Category lists #30264

If no regressions arise, payment will be issued on 2023-11-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@rezkiy37 does not require payment (Contractor)

@rezkiy37

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@rezkiy37] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
[@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@mollfpr

We will need to pay $500 to @mollfpr for testing and review

@mollfpr

@mollfpr offer here: https://www.upwork.com/nx/wm/offer/27545426

@puneetlath

@puneetlath I'll do a manual request in NewDot. Could you give the payment summary? Thank you!

@mollfpr

Ah whoops. Didn't realize you were being paid there now!

Payment summary:

C+ internal PR - @mollfpr - $500

@mollfpr

I think we can close now as @mollfpr is paid in Newdot

Navigation Menu

Repository navigation

[HOLD for payment 2023-11-09] [Wave 6: Categories] Design follow up to Tag and Category lists #29574

17 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-11-09] [Wave 6: Categories] Design follow up to Tag and Category lists #29574

Description

Activity

melvin-bot commented on Oct 13, 2023

shawnborton commented on Oct 13, 2023

shawnborton commented on Oct 13, 2023

puneetlath commented on Oct 13, 2023

shawnborton commented on Oct 13, 2023

17 remaining items

melvin-bot commented on Nov 2, 2023

melvin-bot commented on Nov 2, 2023

melvin-bot commented on Nov 2, 2023

mountiny commented on Nov 2, 2023

puneetlath commented on Nov 6, 2023

mollfpr commented on Nov 6, 2023

puneetlath commented on Nov 6, 2023

mountiny commented on Nov 7, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions