Repository navigation
[Collect Approvers] Add Approve and Pay buttons by using report NextSteps #29145
Description
On hold for https://github.com/Expensify/Expensify/issues/323548
On hold now for https://github.com/Expensify/Web-Expensify/pull/39328
Coming from this internal discussion, we're going to use the report NextSteps data from OldDot to render the Approve or Pay button for collect policies according to the user.
Additionally, we want to render the "approved" message in the corresponding places listed in the HL, like in the report header, report preview and the expense report.
Activity
marcochavezf commentedon Oct 11, 2023
Fixed more edge cases that I've found but in the frontend. Tomorrow I will run another set of local tests to prepare the PR for review.
[-][HOLD][Collect Approvers] Add Approve and Pay buttons by using report NextSteps[/-][+][Collect Approvers] Add Approve and Pay buttons by using report NextSteps[/+]marcochavezf commentedon Oct 12, 2023
PR in review
marcochavezf commentedon Oct 17, 2023
PR updated to fix https://github.com/Expensify/Expensify/issues/325515
marcochavezf commentedon Oct 24, 2023
I'm working on the backend PRs, more details here.
[-][Collect Approvers] Add Approve and Pay buttons by using report NextSteps[/-][+][HOLD Web-E #39328][Collect Approvers] Add Approve and Pay buttons by using report NextSteps[/+][-][HOLD Web-E #39328][Collect Approvers] Add Approve and Pay buttons by using report NextSteps[/-][+][Collect Approvers] Add Approve and Pay buttons by using report NextSteps[/+]9 remaining items
shubham1206agra commentedon Dec 13, 2023
Please assign me here as C+
melvin-bot commentedon Dec 14, 2023
@marcochavezf Eep! 4 days overdue now. Issues have feelings too...
melvin-bot commentedon Dec 18, 2023
@marcochavezf Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!
melvin-bot commentedon Dec 20, 2023
Triggered auto assignment to @dylanexpensify (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.marcochavezf commentedon Dec 20, 2023
Hi @dylanexpensify, could you handle the payment for @shubham1206agra for #28976? 🙇🏽
dylanexpensify commentedon Dec 20, 2023
Yes, will do!
dylanexpensify commentedon Dec 20, 2023
@shubham1206agra please apply here!
shubham1206agra commentedon Dec 20, 2023
Applied
marcochavezf commentedon Dec 21, 2023
Ok, I think we can close it out. Thanks! Also, the PR hit production last week