[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] iOS native - App crashes when going back on a Manual request

[trjExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.3.79-3
Reproducible in staging?: Y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @MitchExpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696874025934959

Action Performed:

1. "+"
2. "Request money"
3. Enter manual amount
4. "Next"
5. Click a contact (Do not "split")
6. "<" Go back in the header beside "Manual"
7. "<" Go back in the header beside "Split"
8. "Next"

Expected Result:

App doesn't crash

Actual Result:

App crashes

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

RPReplay_Final1696873974.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01426d1c07ab30e760
• Upwork Job ID: 1711444561430691840
• Last Price Increase: 2023-10-09
• Automatic offers:
• aimane-chnaif | Reviewer | 27141426
• hungvu193 | Contributor | 27141428

[melvin-bot]

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01426d1c07ab30e760

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[yh-0218]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when going back on a Manual request

What is the root cause of that problem?

This error happen on all devices, not only native mobiles.
On native mobiles, app will be crashed.
On chrome, only console error.
The root cause of this error is same screen is appeared when click Next Button.
When click Next Button, we must move to Split screen from Manual Amount Input Screen

What changes do you think we should make in order to solve the problem?

App/src/libs/actions/IOU.js

Lines 2274 to 2276 in 8d42ad3

	if (shouldReset) {
	resetMoneyRequestInfo(moneyRequestID);
	}

This function reset all request info and go to input screen again.
We need to call secondResetMoneyRequestInfo instead of resetMoneyRequestInfo

function secondResetMoneyRequestInfo(id = '') {
    Onyx.merge(ONYXKEYS.IOU, {
        id,
        billable: null,
    });
}

Result

Screen.Recording.2023-10-09.at.11.10.49.PM.mov

Screen.Recording.2023-10-09.at.11.11.49.PM.mov

What alternative solutions did you explore? (Optional)

[Vadym-33]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when going back on a Manual request

What is the root cause of that problem?

App/src/components/OptionsSelector/BaseOptionsSelector.js

Lines 73 to 75 in 8d42ad3

	setTimeout(() => {
	this.textInput.focus();
	}, CONST.ANIMATED_TRANSITION);

Because of calling focus of null.

What changes do you think we should make in order to solve the problem?

We can add check logic there and this works very well on my side.

setTimeout(() => {
        if (!this.textInput) {
                return;
        }
         this.textInput.focus();
 }, CONST.ANIMATED_TRANSITION);

What alternative solutions did you explore? (Optional)

[mountiny]

@aimane-chnaif lets prioritize this one as its important flow in coming 2 weeks. thanks!

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There are 2 issues here

• When click Next on amount input screen, participants selector screen shows briefly and disappears. Instead amount input screen reappears again. - [$500] Request Money - Request money screen opens again on click of Next button #28129
• App crashes during this transition

As first bug is dupe of #28129, I will provide root cause & solution only for 2nd bug here

What is the root cause of that problem?

Participants selector screen uses BaseOptionsSelector component.
It uses setTimeout to autofocus input. But if component is unmounted quickly before 300ms, this.textInput becomes undefined and it tries to call undefined.focus() which makes crash.
This happens because there's no clearTimeout call on component unmount.

App/src/components/OptionsSelector/BaseOptionsSelector.js

Lines 73 to 76 in d916eff

	setTimeout(() => {
	this.textInput.focus();
	}, CONST.ANIMATED_TRANSITION);
	}

What changes do you think we should make in order to solve the problem?

We already have clear logic here

App/src/components/OptionsSelector/BaseOptionsSelector.js

Lines 136 to 139 in d916eff

	componentWillUnmount() {
	if (this.focusTimeout) {
	clearTimeout(this.focusTimeout);
	}

this.focusTimeout definition was somehow missing so we can add it back:

     this.focusTimeout = setTimeout(() => { 
         this.textInput.focus(); 
     }, CONST.ANIMATED_TRANSITION)