Skip to content

[HOLD for payment 2023-11-01] Category IOU - Admin is unable to edit Category for a paid request #28963

Closed
Closed
[HOLD for payment 2023-11-01] Category IOU - Admin is unable to edit Category for a paid request#28963
Assignees
puneetlathfedirjhrezkiy37
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Description

@lanitochka17
lanitochka17
opened on Oct 5, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Precondition: User has created a workspace in OD and invited an employee

  1. Log in to staging,new,expensify.com as an employee
  2. As an employee, create a money request with a category from the workspace chat
  3. After the request is created, disable all categories on OD as admin
  4. As admin, pay the IOU request and go to IOU report
  5. As admin, return to OD and enable all categories
  6. As admin, go back to the paid IOU report

Expected Result:

Admin is able to edit Category for a paid request

Actual Result:

Admin is unable to edit Category for a paid request

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.78-3

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6226489_1696539436977.20231006_031923__1_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. lanitochka17
    added
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 5, 2023
  2. melvin-bot
    assigned
    trjExpensify
    on Oct 5, 2023

  3. melvin-bot commented on Oct 5, 2023

    @melvin-bot
    melvin-botBot
    on Oct 5, 2023

    Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. melvin-bot commented on Oct 5, 2023

    @melvin-bot
    melvin-botBot
    on Oct 5, 2023

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

  5. trjExpensify commented on Oct 6, 2023

    @trjExpensify
    trjExpensify
    on Oct 6, 2023
    Contributor

    👋 @lanitochka17 just a heads up that a request on a workspace is added to an expense report not an iou report. The repro steps state iouReport but the video shows an expenseReport because it's to the workspace.

  6. trjExpensify commented on Oct 6, 2023

    @trjExpensify
    trjExpensify
    on Oct 6, 2023
    Contributor

    Also, the expected and actual results are the same.

    Expected Result:
    Admin is able to edit Category for a paid request

    Actual Result:
    Admin is able to edit Category for a paid request

  7. trjExpensify commented on Oct 6, 2023

    @trjExpensify
    trjExpensify
    on Oct 6, 2023
    Contributor

    @puneetlath @rezkiy37 @waterim @joekaufmanexpensify categories bug, who wants it? 😅

  8. puneetlath
    assigned
    puneetlath
    and unassigned
    trjExpensify
    on Oct 6, 2023
  9. puneetlath
    added this to [#whatsnext] Wave 06 - Collect Submitterson Oct 6, 2023
  10. puneetlath
    moved this to LOW in [#whatsnext] Wave 06 - Collect Submitterson Oct 6, 2023

  11. puneetlath commented on Oct 6, 2023

    @puneetlath
    puneetlath
    on Oct 6, 2023
    Contributor

    Ahh, interesting. I can take over the BZ from you @trjExpensify.

    @rezkiy37 would you want to look into it?

  12. rezkiy37 commented on Oct 6, 2023

    @rezkiy37
    rezkiy37
    on Oct 6, 2023
    Contributor

    Hi, I’m Michael (Mykhailo) from Callstack and I would like to work in this issue.

  13. rezkiy37 commented on Oct 6, 2023

    @rezkiy37
    rezkiy37
    on Oct 6, 2023
    Contributor

    👋 @lanitochka17 just a heads up that a request on a workspace is added to an expense report not an iou report. The repro steps state iouReport but the video shows an expenseReport because it's to the workspace.

    Just to clarify: from tech. perspective is it still an iOU?

    Screenshot 2023-10-06 at 13 26 36

  14. 20 remaining items

  15. melvin-bot commented on Oct 25, 2023

    @melvin-bot
    melvin-botBot
    on Oct 25, 2023

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. melvin-bot commented on Oct 25, 2023

    @melvin-bot
    melvin-botBot
    on Oct 25, 2023

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.90-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-11-01. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    • @rezkiy37 does not require payment (Contractor)

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty

  17. melvin-bot commented on Oct 25, 2023

    @melvin-bot
    melvin-botBot
    on Oct 25, 2023

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@puneetlath] The PR that introduced the bug has been identified. Link to the PR:
    • [@puneetlath] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@puneetlath] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@rezkiy37] Determine if we should create a regression test for this bug.
    • [@rezkiy37] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  18. puneetlath
    assigned
    fedirjh
    on Oct 25, 2023

  19. puneetlath commented on Oct 25, 2023

    @puneetlath
    puneetlath
    on Oct 25, 2023
    Contributor

    @fedirjh was the C+ here.

    @fedirjh could you please handle the checklist?

  20. puneetlath commented on Oct 30, 2023

    @puneetlath
    puneetlath
    on Oct 30, 2023
    Contributor

    Friendly reminder about the checklist so that we can pay on Wednesday.

  21. fedirjh commented on Oct 30, 2023

    @fedirjh
    fedirjh
    on Oct 30, 2023
    Contributor

    BugZero Checklist:

    • Link to the PR: I don't think this is a regression, it seems this behavior wasn't present in the initial implementation of categories in this PR Allow Viewing/Editing a category on a Money Request #27459
    • Link to comment: N/A
    • Link to discussion: N/A
    • Determine if we should create a regression test for this bug: Yes

    Regression Test Proposal

    Expense report:

    1. As an employee, Open a chat with a workspace where you are a member.
    2. Create a money request using different variants such as manual, distance, and receipt.
    3. Open the money request page for each request within the expense report.
    4. As an employee, Verify that you can modify all values.
    5. As admin, Open the expense report page with the employee
    6. Open the money request page of each request inside the expense report
    7. As admin, Verify that you can modify all values.
    8. Navigate back to the expense report and mark it as paid
    9. Open the money request page
    10. As admin, Verify that you can modify all values, except: amount, currency, date, distance and receipt.
    11. As an employee, Verify that you cannot modify any value.

    IOU report:

    1. As UserA, Open a chat with UserB.
    2. Create a money request.
    3. Open the details page of the report.
    4. Verify that you can modify all values.
    5. Open the app from UserB.
    6. Open the same IOU details page.
    7. Verify that you cannot modify any value.
    8. Mark the request as paid.
    9. Verify that neither UserA nor UserB can modify any values.
    • Do we agree 👍 or 👎

  22. rezkiy37 commented on Oct 31, 2023

    @rezkiy37
    rezkiy37
    on Oct 31, 2023
    Contributor

    I have to inform that starting tomorrow I have a short vocation until next Monday (6.11.2023). Feel free to left any comments, I will address them. See you soon 😉

  23. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Nov 1, 2023

  24. puneetlath commented on Nov 1, 2023

    @puneetlath
    puneetlath
    on Nov 1, 2023
    Contributor

    @fedirjh Upwork offer is here: https://www.upwork.com/nx/wm/offer/27475726

    Please ping me on the issue when you've accepted.

  25. fedirjh commented on Nov 1, 2023

    @fedirjh
    fedirjh
    on Nov 1, 2023
    Contributor

    @puneetlath Thank you. Accepted.

  26. puneetlath commented on Nov 1, 2023

    @puneetlath
    puneetlath
    on Nov 1, 2023
    Contributor

    All paid, thanks everyone!

  27. puneetlath
    closed this as completedon Nov 1, 2023
  28. github-project-automation
    moved this from LOW to Done in [#whatsnext] Wave 06 - Collect Submitterson Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions