[HOLD for payment 2023-10-16] [HOLD for payment 2023-10-13] Task - No-entry mouse sign is displayed when hovering over 'Chevron' icon options displayed on 'Confirm task' page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on 'FAB' menu
2. Click on 'Assign task'
3. Enter title & click 'Next'
4. Hover over the chevron icon of 'Title', 'Assignee', 'Description', and 'Share somewhere' fields

Expected Result:

Hand icon should be displayed and the chevron icon should be clickable

Actual Result:

No-entry mouse sign is displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native - mouse hover effect can't be tested
• Android / Chrome - mouse hover effect can't be tested
• iOS / native - mouse hover effect can't be tested
• iOS / Safari - mouse hover effect can't be tested
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.78.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-10-05.at.11.54.52.AM.mov

Screen.Recording.2023-10-05.at.11.43.46.AM.mov

Recording.4861.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696495753528999

View all open jobs on GitHub

[ishpaul777]

Proposal

Problem

not allowed cursor is displayed when hovering over 'Chevron' icon options displayed on 'Confirm task' page

Root cause

The PressableWithFeedBack component for right chevron icon has a disabled prop set to !props.onIconRightPress, we are not passing onIconRightPress prop to the component, so it is undefined and disabled prop is set to true. In fact we are not using onIconRightPress prop any of the MenuItem across the app.

App/src/components/MenuItem.js

Line 353 in 25f7ac1

disabled={!props.onIconRightPress}

offending PR : #26789

Solution

We need to modify the disabled prop to props.disabled instead of !props.onIconRightPress in PressableWithFeedBack component for right chevron icon in MenuItem component or we can remove the disabled prop also

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[dukenv0307]

I think this is regression from this PR #26778

[saranshbalyan-1234]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Cursor is disabled on Right Icon on Confirm Task Page

What is the root cause of that problem?

We are handling different onPress event for iconRight, We have passed shouldShowRightIcon but have not passed onIconRightPress here.

App/src/pages/tasks/NewTaskPage.js

Lines 181 to 188 in 0cbee22

	<MenuItem
	label={assignee.displayName ? props.translate('task.assignee') : ''}
	title={assignee.displayName || ''}
	description={assignee.displayName ? LocalePhoneNumber.formatPhoneNumber(assignee.subtitle) : props.translate('task.assignee')}
	icon={assignee.icons}
	onPress={() => Navigation.navigate(ROUTES.NEW_TASK_ASSIGNEE)}
	shouldShowRightIcon
	/>

There is however one condition on onIconRightPress which is, if no present make the iconRight disabled, the below code will explain this line

App/src/components/MenuItem.js

Lines 352 to 354 in 180fd60

	accessible={!props.onIconRightPress}
	disabled={!props.onIconRightPress}
	onPress={props.onIconRightPress}

What changes do you think we should make in order to solve the problem?

We have to pass another prop which is onIconRightPress same as onPress like this

             <MenuItem
                        key={item.translationKey}
                        onPress={() => item.action()}
                        onIconRightPress={() => item.action() }

After passing this prop it will show the same cursor on iconRight and onPress will work as well as on hover it will show the expected behaviour

What alternative solutions did you explore? (Optional)

Or what we can do is by default onIconRightPress should be same as onPress prop in the MenuItem.js. This would keep the rightIcon work similar to the old behaviour till onIconRightPress prop is passed explicitly.

[rezkiy37]

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work in this issue.