[HOLD for payment 2023-10-30] Distance IOU - Map preview is not extended to full view on RHP

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #26307

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Go to + > Request money > Distance

Expected Result:

Map preview is extended to full view on RHP

Actual Result:

Map preview is not extended to full view on RHP

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.78-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6225725_1696502445231.20231005_180639.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On distance request page, map preview is not extended to full view on RHP

What is the root cause of that problem?

In the newly created DraggableList component, we wrap all contents inside ScrollView as you can see

App/src/components/DraggableList/index.tsx

Line 73 in eb5e1e8

<ScrollView

ScrollView has style flex1 so that it covers all possible space, but this ScrollView component has a content container in it. Please refer https://reactnative.dev/docs/scrollview#contentcontainerstyle. We doesn't set the style of this content container so the container doesn't cover the possible space.

This is the root cause

What changes do you think we should make in order to solve the problem?

Set the contentContainerStyle of ScrollView to styles.flex1

This works as expected

Result

What alternative solutions did you explore? (Optional)

[hayata-suenaga]

tagged PR author (SWM engineer) here and C+ here

[situchan]

What will be max height on mobile?