Skip to content

[WAITING ON CHECKLIST] [HOLD for payment 2023-10-23] [$500] [Form Provider Refactor] NewDatePicker #28879

Closed
Closed
[WAITING ON CHECKLIST] [HOLD for payment 2023-10-23] [$500] [Form Provider Refactor] NewDatePicker#28879
Assignees
mananjadhavluacmartinsjliexpensifykowczarz
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Description

@luacmartins
luacmartins
opened on Oct 4, 2023

Coming from #25397 (comment), we created a new Form provider that works with functional components and we need to refactor all usages of the old Form component.

This issue is specific to refactoring src/components/NewDatePicker/index.js

cc @kowczarz

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e08fcb9456de83d2
  • Upwork Job ID: 1709706449708163072
  • Last Price Increase: 2023-10-05

Activity

  1. luacmartins
    added
    DailyKSv2
    InternalRequires API changes or must be handled by Expensify staff
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 4, 2023
  2. luacmartins
    self-assigned this
    on Oct 4, 2023
  3. melvin-bot
    assigned
    jliexpensify
    on Oct 4, 2023

  4. melvin-bot commented on Oct 4, 2023

    @melvin-bot
    melvin-botbot
    on Oct 4, 2023

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  5. melvin-bot commented on Oct 4, 2023

    @melvin-bot
    melvin-botbot
    on Oct 4, 2023

    Job added to Upwork: https://www.upwork.com/jobs/~01e08fcb9456de83d2

  6. melvin-bot commented on Oct 4, 2023

    @melvin-bot
    melvin-botbot
    on Oct 4, 2023

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  7. melvin-bot
    assigned
    mananjadhav
    on Oct 4, 2023

  8. melvin-bot commented on Oct 4, 2023

    @melvin-bot
    melvin-botbot
    on Oct 4, 2023

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @mananjadhav (Internal)

  9. kowczarz commented on Oct 5, 2023

    @kowczarz
    kowczarz
    on Oct 5, 2023
    Contributor

    Hello! I'm Kamil Owczarz from Software Mansion, the expert agency and I would like to work on this task.

  10. luacmartins
    assigned
    kowczarz
    on Oct 5, 2023
  11. luacmartins
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    InternalRequires API changes or must be handled by Expensify staff
    on Oct 5, 2023
  12. melvin-bot
    changed the title [-][Form Provider Refactor] NewDatePicker[/-] [+][$500] [Form Provider Refactor] NewDatePicker[/+] on Oct 5, 2023

  13. 31 remaining items

  14. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Oct 20, 2023

  15. jliexpensify commented on Oct 22, 2023

    @jliexpensify
    jliexpensify
    on Oct 22, 2023
    Contributor

    Payment Summary:

    NO UPWORKS JOB NEEDED

  16. jliexpensify commented on Oct 24, 2023

    @jliexpensify
    jliexpensify
    on Oct 24, 2023
    Contributor

    @mananjadhav bump to complete the checklist (if required)!

  17. jliexpensify
    changed the title [-][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] [Form Provider Refactor] NewDatePicker[/-] [+][WAITING ON CHECKLIST] [HOLD for payment 2023-10-23] [$500] [Form Provider Refactor] NewDatePicker[/+] on Oct 24, 2023

  18. mananjadhav commented on Oct 24, 2023

    @mananjadhav
    mananjadhav
    on Oct 24, 2023
    Collaborator

    @jliexpensify There won't be any payout for me. @aimane-chnaif reviewed the PR, and their payout will be handled in this issue. Also it is a refactor, hence there won't be any checklist.

  19. jliexpensify commented on Oct 24, 2023

    @jliexpensify
    jliexpensify
    on Oct 24, 2023
    Contributor

    Thanks Manan, closing this one out!

  20. jliexpensify
    closed this as completedon Oct 24, 2023
  21. melvin-bot
    added
    ReviewingHas a PR in review
    WeeklyKSv2
    and removed
    DailyKSv2
    on Nov 13, 2023
  22. melvin-bot
    added
    WeeklyKSv2
    and removed
    WeeklyKSv2
    on Jan 18, 2024
  23. melvin-bot
    added
    WeeklyKSv2
    and removed
    WeeklyKSv2
    on Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions