Repository navigation
[HOLD for payment 2023-12-06] [ECARD] CRITICAL: Transactions - Enable MoneyRequestView Edit Transactions Logic #28836
Description
Activity
Job added to Upwork: https://www.upwork.com/jobs/~0149be352f2615a7b7
Triggered auto assignment to Contributor Plus for review of internal employee PR - @akinwale (
Internal)Triggered auto assignment to @Christinadobrzyn (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.HOLD on edit functionality
cc @luacmartinsReacted by Christina Dobrzynski35 remaining items
Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.4-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-12-06. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
- External issue reporter
- Contributor that fixed the issue
- Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
- @akinwale requires payment
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@akinwale] The PR that introduced the bug has been identified. Link to the PR:
- [@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@akinwale] Determine if we should create a regression test for this bug.
- [@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Design Doc Section
Overview
Goal: We need to Hold on updates to EditMoneyRequest to handle card transactions. Once that’s complete, we will add the edit logic for non reimbursable transactions to NewDot.
Upwork Automation - Do Not Edit
I checked your job posted on Upwork https://www.upwork.com/jobs/~0178d694337026c11f , FYI its private job i.e, its details are not visible in upwork. You may need to correct the access while generating JOB via bot :)
Hi, I'm in interested in the project, let me know when we can have a quick discussion call?
📣 @codewithnimesh! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:- Make sure you've read and understood the contributing guidelines.
- Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
- Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
- Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details Your Expensify account email: <REPLACE EMAIL HERE> Upwork Profile Link: <REPLACE LINK HERE>Hi @codewithnimesh! Thanks for reaching out - this job is complete but feel free to apply to any jobs that have a Help Wanted label in our Expensify/App repo - https://github.com/Expensify/App/issues?q=is%3Aopen+is%3Aissue+label%3A%22Help+Wanted%22
@akinwale I paid you in Upwork based on the payment structure here - #28836 (comment)
Closing this but let me know if I'm missing anything!
Reacted by Akinwale Ariwodola- moved this from CRITICAL to Done in [#whatsnext] Wave 05 - Deprecate Free
on Dec 8, 2023
Design Doc Section
https://docs.google.com/document/d/1iELOXPOAcnuIPZJ3XbO1S8_3qHaM31Ptf8dR4LRZMyE/edit#bookmark=id.qpl4zgrq5w2x
Overview
Goal:
We need to Hold on updates to EditMoneyRequest to handle card transactions. Once that’s complete, we will add the edit logic for non reimbursable transactions to NewDot.
Upwork Automation - Do Not Edit