[HOLD for payment 2023-10-30] [$500] Workspace - Workspace invite page appears for sometime before Hmm its not here on visit after delete

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open settings->workspaces->any workspace->members->invite
3. Copy the URL
4. Delete the workspace used in step 2
5. Paste URL copied in step 3 and visit it
6. Observe that app displays invite member page for sometime before displaying Hmm its not here page

Expected Result:

App should display hmm its not here page for workspace pages after workspace is deleted

Actual Result:

App displays invite page for sometime before displaying hmm its not here page on visiting invite page after workspace is deleted

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / safari
• Windows / Chrome
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.74-2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

mac.chrome.ios.safari.invite.URL.workspace.reload.delete.mov

Recording.102.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695834960413269

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0142517c9700246d09
• Upwork Job ID: 1707425807494483968
• Last Price Increase: 2023-10-12
• Automatic offers:
• c3024 | Contributor | 27249053
• dhanashree-sawant | Reporter | 27249055

[c3024]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Accessing invite members link of a deleted workspace shows the invite page briefly before showing not found page

What is the root cause of that problem?

In this here

App/src/pages/workspace/WorkspaceInvitePage.js

Line 209 in e2c9203

shouldShow={((_.isEmpty(props.policy) || !PolicyUtils.isPolicyAdmin(props.policy)) && !props.isLoadingReportData) || PolicyUtils.isPendingDeletePolicy(props.policy)}

shouldShow of FullPageNotFoundView is invariably false when isLoadingReportData is true (and when PolicyUtils.isPendingDeletePolicy(props.policy) is false as well). So when we access the invite page by deep link the report gets loaded and the not found page is not shown while the report is loading.
Since we are not using any loading indicator, the invite page appears for a brief moment before the not found page appears.

What changes do you think we should make in order to solve the problem?

Wrap the WorkspaceInvitePage with withPolicyAndFullscreenLoading

App/src/pages/workspace/WorkspaceInvitePage.js

Line 259 in fbd04cf

withPolicy,

With this it first shows loading indicator and then shows the not found page.

We should also change the check for showing not found page like this

shouldShow={(_.isEmpty(props.policy) && !props.isLoadingReportData) || !PolicyUtils.isPolicyAdmin(props.policy) || PolicyUtils.isPendingDeletePolicy(props.policy)}               

so that if the policy is already loaded (because say the user is a member of the workspace) we can check if the user is an admin and show the not found page right away.
We will consider isLoadingReportData only when the policy is empty to show or not show the not found page.

We can do the same for the members page, currency page and any other pages as required.

What alternative solutions did you explore? (Optional)

Alternatively we can show a loading indicator if the policy is fetched for the first time by adding this

    if (_.isEmpty(props.policy) && props.isLoadingReportData) {
        return <FullScreenLoadingIndicator />;
    }

here

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0142517c9700246d09

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[stephanieelliott]

Was able to repro. @rushatgabhane looks like we have a proposal here, can you review when you get a chance?

[melvin-bot]

@rushatgabhane, @stephanieelliott Whoops! This issue is 2 days overdue. Let's get this updated quick!