[HOLD for payment 2023-10-16] [$500] Attachment - Red error message appears briefly when closing password protected PDF

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Action Performed:

1. Go any report
2. Open password protected PDF page
3. Click close button, Observe error message appears briefly

Expected Result:

No error message after close

Actual Result:

Error message appears briefly after closing password protected PDF

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native - did not provided yet, requested
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.74.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-24.at.17.24.22.mov

Recording.4771.mp4

Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695551022734439

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b3fbc4b9a33f9413
• Upwork Job ID: 1706411843181993984
• Last Price Increase: 2023-10-02
• Automatic offers:
• jjcoffee | Reviewer | 26985177
• namhihi237 | Contributor | 26985179
• namhihi237 | Reporter | 26985182

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b3fbc4b9a33f9413

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @NicMendonca (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[kbecciv]

Proposal by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695551022734439

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error message appears briefly after closing password-protected PDF, It also when we click download

What is the root cause of that problem?

We call the function check error when blur input:

App/src/components/PDFView/PDFPasswordForm.js

Line 129 in 5217721

onBlur={validateAndNotifyPasswordBlur}

In the function validateAndNotifyPasswordBlur we call validate function. That means when we click outside the input> it will tricker and show an error.

App/src/components/PDFView/PDFPasswordForm.js

Lines 98 to 101 in 5217721

	const validateAndNotifyPasswordBlur = () => {
	validate();
	onPasswordFieldFocused(false);
	};

App/src/components/PDFView/PDFPasswordForm.js

Lines 81 to 89 in 5217721

	const validate = () => {
	if (!isPasswordInvalid && !_.isEmpty(password)) {
	return true;
	}
	if (_.isEmpty(password)) {
	setValidationErrorText('attachmentView.passwordRequired');
	}
	return false;
	};

What changes do you think we should make in order to solve the problem?

I think we can remove validation when blur input. We only check when click confirm.

What alternative solutions did you explore? (Optional)

N/A

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We have 2 bugs:

1. Red error message appears briefly when closing password password-protected PDF
2. Red error appear as soon as the app is put in background (ref: [HOLD for payment 2023-08-16] [$1000] Web - Task - Error is shown as soon as app is put in background when creating a task #23552)

Screen.Recording.2023-09-26.at.17.09.37.mov

What is the root cause of that problem?

App/src/components/PDFView/PDFPasswordForm.js

Lines 98 to 102 in 3486648

	const validateAndNotifyPasswordBlur = () => {
	validate();
	onPasswordFieldFocused(false);
	};

This function will be triggered, even though user click on close button or put app in background

What changes do you think we should make in order to solve the problem?

We should trigger the validate function on blur only when the current app is visible and has focus. And then we can use setTimeOut to delay validation like this

const validateAndNotifyPasswordBlur = () => {
        // Only run validation when user proactively blurs the input.
        if (!Visibility.isVisible() || !Visibility.hasFocus()) {
            return
        }
        setTimeout(() => {
            validate();
            onPasswordFieldFocused(false);
        }, 300);
    }

This is the way we did in Form Component and used in many places

App/src/components/Form.js

Line 301 in 4af18f6

setTimeout(() => {

result

Screen-Recording-2023-09-26-at-17.06.09.mp4