Skip to content

[HOLD for payment 2023-10-12] [$500] Chat - Expand button does not show if composer only contains new line #28093

Closed
Closed
[HOLD for payment 2023-10-12] [$500] Chat - Expand button does not show if composer only contains new line#28093
Assignees
abekkalamarcaaronabdulrahuman5196bernhardoj
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Description

@kbecciv
kbecciv
opened on Sep 24, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Action Performed:

  1. Open any chat
  2. Add >= 3 new lines on the composer

Expected Result:

The expand button is shown above + button

Actual Result:

The expand button is not visible until you type a character other than newline/space

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.73.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-22.at.18.36.10.mov
Recording.4738.mp4

Expensify/Expensify Issue URL:
Issue reported by: @bernhardoj
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695387935862449

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d0f3b8c804481cd5
  • Upwork Job ID: 1705987383652581376
  • Last Price Increase: 2023-09-24
  • Automatic offers:
    • abdulrahuman5196 | Reviewer | 26935777
    • bernhardoj | Contributor | 26935778
    • bernhardoj | Reporter | 26935779

Activity

  1. kbecciv
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 24, 2023
  2. melvin-bot
    changed the title [-]Chat - Expand button does not show if composer only contains new line[/-] [+][$500] Chat - Expand button does not show if composer only contains new line[/+] on Sep 24, 2023

  3. melvin-bot commented on Sep 24, 2023

    @melvin-bot
    melvin-botBot
    on Sep 24, 2023

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. melvin-bot
    assigned
    abekkala
    on Sep 24, 2023

  5. melvin-bot commented on Sep 24, 2023

    @melvin-bot
    melvin-botBot
    on Sep 24, 2023

    Job added to Upwork: https://www.upwork.com/jobs/~01d0f3b8c804481cd5

  6. melvin-bot commented on Sep 24, 2023

    @melvin-bot
    melvin-botBot
    on Sep 24, 2023

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  7. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 24, 2023
  8. melvin-bot
    assigned
    sakluger
    on Sep 24, 2023

  9. melvin-bot commented on Sep 24, 2023

    @melvin-bot
    melvin-botBot
    on Sep 24, 2023

    Triggered auto assignment to @sakluger (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  10. melvin-bot
    assigned
    abdulrahuman5196
    on Sep 24, 2023

  11. melvin-bot commented on Sep 24, 2023

    @melvin-bot
    melvin-botBot
    on Sep 24, 2023

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

  12. kbecciv commented on Sep 24, 2023

    @kbecciv
    kbecciv
    on Sep 24, 2023
    Author

    Proposal by: @bernhardoj
    Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695387935862449

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The expand button is not visible if we only have new lines on the composer without any characters.

    What is the root cause of that problem?

    In #27015, we are hiding the expand button if the composer is empty (only contains space).

    App/src/pages/home/report/ReportActionCompose/ReportActionCompose.js

    Line 346 in 7bebfd3

    isFullComposerAvailable={isFullComposerAvailable && !isCommentEmpty}

    It is to fix an issue where the expand button is not immediately hidden after sending a comment and it is their alternative solution, and then based on this comment, they decided to use the main solution instead.
    Then, this comment suggested adding it back but I didn't see any improvement as said in the comment and instead created a regression.

    What changes do you think we should make in order to solve the problem?

    Remove !isCommentEmpty

    App/src/pages/home/report/ReportActionCompose/ReportActionCompose.js

    Line 346 in 7bebfd3

    isFullComposerAvailable={isFullComposerAvailable && !isCommentEmpty}

  13. sofi-a commented on Sep 25, 2023

    @sofi-a
    sofi-a
    on Sep 25, 2023
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The expand button does not show if there are only new lines in the composer.

    What is the root cause of that problem?

    Comments containing only white spaces are considered to be empty.

    App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions.js

    Line 185 in 5099522

    setIsCommentEmpty(!!newComment.match(/^(\s)*$/));

    What changes do you think we should make in order to solve the problem?

    Check if the comment is actually empty instead of checking if it only contains whitespaces.

                setIsCommentEmpty(_.isEmpty(newComment));

    What alternative solutions did you explore? (Optional)

    Remove !isCommentEmpty here.

  14. 25 remaining items

  15. melvin-bot
    added
    WeeklyKSv2
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    WeeklyKSv2
    on Oct 5, 2023
  16. melvin-bot
    changed the title [-][$500] Chat - Expand button does not show if composer only contains new line[/-] [+][HOLD for payment 2023-10-12] [$500] Chat - Expand button does not show if composer only contains new line[/+] on Oct 5, 2023
  17. melvin-bot
    removed
    ReviewingHas a PR in review
    on Oct 5, 2023

  18. melvin-bot commented on Oct 5, 2023

    @melvin-bot
    melvin-botBot
    on Oct 5, 2023

    Reviewing label has been removed, please complete the "BugZero Checklist".

  19. melvin-bot commented on Oct 5, 2023

    @melvin-bot
    melvin-botBot
    on Oct 5, 2023

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.77-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-10-12. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty

  20. melvin-bot commented on Oct 5, 2023

    @melvin-bot
    melvin-botBot
    on Oct 5, 2023

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
    • [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@abdulrahuman5196] Determine if we should create a regression test for this bug.
    • [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: N/A

  21. abekkala commented on Oct 10, 2023

    @abekkala
    abekkala
    on Oct 10, 2023
    Contributor

    PAYMENTS FOR OCT 12

    • @bernhardoj (Reporter) [$50]
    • @bernhardoj (Contributor) [$500 + $250 bonus, if no regression]
    • @abdulrahuman5196 (Reviewer) [$500 + $250 bonus, if no regression] - please complete the checklist above before payments are processed

  22. abdulrahuman5196 commented on Oct 10, 2023

    @abdulrahuman5196
    abdulrahuman5196
    on Oct 10, 2023
    Contributor

    The PR that introduced the bug has been identified. Link to the PR:

    #27015

    The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    https://github.com/Expensify/App/pull/27015/files#r1352818508

    Determine if we should create a regression test for this bug.
    If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    No. Regression tests is not beneficial for this minor case.

  23. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Oct 11, 2023

  24. abekkala commented on Oct 12, 2023

    @abekkala
    abekkala
    on Oct 12, 2023
    Contributor

    @abdulrahuman5196 [$750] payment made and contract ended - thank you! 🎉

  25. abekkala commented on Oct 12, 2023

    @abekkala
    abekkala
    on Oct 12, 2023
    Contributor

    @bernhardoj [$800] payment made and contract ended - thank you! 🎉

  26. abekkala
    closed this as completedon Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions