[HOLD for payment 2023-10-18] [$500] I cursor not displayed on profile error

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open settings->profile->upload invalid format image or more then 6mb image
3. App will display error below profile pic
4. Hover and try to select the error, observe that app displays normal cursor and does not allow to select the error
5. Similarly try on error in new contact method i.e. add a new contact method and insert wrong code
6. Hover and observe that it displays I cursor which is correct and allows to select the error (all other errors throughout app displays I cursor and allows to select the text)

Expected Result:

App should display I cursor over errors and allow to select and copy the text

Actual Result:

Profile pic error displays normal cursor and does not allow to select and copy the text

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.76-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

I.cursor.not.displayed.on.profile.error.2.mp4

bandicam.2023-09-22.15-29-39-962.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695035097969079

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e242f576582d3c21
• Upwork Job ID: 1705250624405737472
• Last Price Increase: 2023-09-22
• Automatic offers:
• dukenv0307 | Contributor | 26936356
• Dhanashree-Sawant | Reporter | 26936357

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e242f576582d3c21

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[kavimuru]

Proposal from @dhanashree-sawant

Please re-state the problem that we are trying to solve in this issue.

We are solving the problem of normal cursor on profile error and error not selectable

What is the root cause of that problem?

On Main View of profile page, we have explicitly set user-select:none because of which it displays normal cursor on profile error

What changes do you think we should make in order to solve the problem?

Set user-select:text on DotIndicatorMessage component of error on profile page
We can do that by adding new style here

dotIndicatorMessageSelect: {
    ...userSelect.userSelectText
},

Assign that style to DotIndicatorMessage in AvatarWithImagePicker.js here

style={[styles.mt6, styles.dotIndicatorMessageSelect]}

What alternative solutions did you explore? (Optional)

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

[saranshbalyan-1234]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On Profile error instead of text cursor it is showing default cursor.

What is the root cause of that problem?

We are not setting cursor style on the error message

What changes do you think we should make in order to solve the problem?

Just need to pass this style (styles.cursorText)

App/src/components/AvatarWithImagePicker.js

Lines 361 to 368 in f39184e

	</View>
	{this.state.validationError && (
	<DotIndicatorMessage
	style={[styles.mt6]}
	messages={{0: this.props.translate(this.state.validationError, this.state.phraseParam)}}
	type="error"
	/>
	)}

which would look like

   {this.state.validationError && (
                    <DotIndicatorMessage
                        style={[styles.mt6, styles.cursorText]}
                        messages={{0: this.props.translate(this.state.validationError, this.state.phraseParam)}}
                        type="error"
                    />
                )}

What alternative solutions did you explore? (Optional)

N/A