[HOLD for payment 2024-01-05] [$500] Web - Message background color is stuck on cancel delete

@dhanashree-sawant

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open the app
Open any report
Send any message
Right click on that message and click on delete comment
Click on cancel and now observe that irrespective on whichever message we hover, background color is stuck on message used in step 4

Expected Result:

App should remove background color from message as soon as we hover on any other message

Actual Result:

Background color on message is stuck when we right click on any message, click delete and cancel the delete

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.73.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

background.color.on.message.is.stuck.on.delete.and.cancel.mp4

Recording.4693.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695223040847299

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~013ba33594e38dfae9
Upwork Job ID: 1705250597563105280
Last Price Increase: 2023-10-13
Automatic offers:

bernhardoj | Contributor | 28037564

Job added to Upwork: https://www.upwork.com/jobs/~013ba33594e38dfae9

@anmurali

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@anmurali

Triggered auto assignment to @anmurali (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@thesahindia

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

The problem is that the background highlight colour on a selected message does not disappear when selecting the 'Delete Comment' popup modal and then cancelling the operation.

What is the root cause of that problem?

The issue is that the onPopoverHide() callback to handle state updates can only be called once, due to the use of the 'run and reset' paradigm. In this specific situation, this callback needs to be handled twice – once when the context menu closes, and again when the confirm delete modal changes. Since this callback is called first when the context menu closes, the subsequent cancellation of the delete modal does not call the callback to update the state of the component.

What changes do you think we should make in order to solve the problem?

We allow the onPopoverHide() callback to be called several times, by not clearing the callback after the first run.

I already have a simple and elegant working solution that only requires three lines of code to be changed.

@Samueljh1

📣 @Samueljh1! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Contributor details
Your Expensify account email: samueljh01+test@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01a7dc17eccbc9dc59

@parasharrajat

Payment summary for contributor payments on New Dot
-[ ] $500 to @parasharrajat on ND is approved to process

@dhanashree-sawant

@dhanashree-sawant - sent you an offer

@anmurali

Thanks @anmurali, I have accepted the offer.

@anmurali

@anmurali, @blimpich, @parasharrajat, @bernhardoj Huh... This is 4 days overdue. Who can take care of this?

Let's close this issue. I will request it later.

@anmurali

@anmurali, @blimpich, @parasharrajat, @bernhardoj Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@dhanashree-sawant

@dhanashree-sawant is paid. @parasharrajat - I will let you request this when you are ready.

Payment requested as per #28029 (comment)

@parasharrajat

$500 approved for @parasharrajat

Navigation Menu

Repository navigation

[HOLD for payment 2024-01-05] [$500] Web - Message background color is stuck on cancel delete #28029

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

148 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-01-05] [$500] Web - Message background color is stuck on cancel delete #28029

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Sep 22, 2023

melvin-bot commented on Sep 22, 2023

melvin-bot commented on Sep 22, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Sep 22, 2023

melvin-bot commented on Sep 22, 2023

Samueljh1 commented on Sep 22, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

melvin-bot commented on Sep 22, 2023

Samueljh1 commented on Sep 22, 2023

148 remaining items

anmurali commented on Jan 10, 2024

anmurali commented on Jan 10, 2024

dhanashree-sawant commented on Jan 10, 2024

melvin-bot commented on Jan 15, 2024

parasharrajat commented on Jan 16, 2024

melvin-bot commented on Jan 19, 2024

anmurali commented on Jan 22, 2024

parasharrajat commented on Apr 5, 2024

JmillsExpensify commented on Apr 8, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions