[$500] chat thread report header is incorrectly showing the "root" report in second line rather than the "parent" report.

Reproduction steps

Comment in a parent report (e.g. root report)
Create a thread on your comment in the parent/root (e.g. thread1)

3. Confirm that in the header for thread1 shows the name of the parent/root report.

4. Now create another thread on your comment in thread1 (e.g. thread2)

5. Notice that the header of thread2 incorrectly shows the root report in the second line of the header, which is incorrect. The second line should instead show thread1, which is the parent of thread2.

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~014565dfd91b80271a
Upwork Job ID: 1706507483408605184
Last Price Increase: 2023-10-17

@kevinksullivan

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Originally reported internally in Slack.

Proposal

Please re-state the problem that we are trying to solve in this issue.

chat thread report header is incorrectly showing the "root" report in second line rather than the "parent" report.

What is the root cause of that problem?

In getRootReportAndWorkspaceName function, we have an infinity loop here to get the root parent report name of the thread report

App/src/libs/ReportUtils.js

Lines 1743 to 1746 in 8e2edbf

    
           if (isChildReport(report) && !isMoneyRequestReport(report) && !isTaskReport(report)) { 
        
               const parentReport = lodashGet(allReports, [`${ONYXKEYS.COLLECTION.REPORT}${report.parentReportID}`]); 
        
               return getRootReportAndWorkspaceName(parentReport); 
        
           }

What changes do you think we should make in order to solve the problem?

We should remove this infinity loop to get the name of the previous parent report of the thread.

App/src/libs/ReportUtils.js

Lines 1743 to 1746 in 8e2edbf

    
           if (isChildReport(report) && !isMoneyRequestReport(report) && !isTaskReport(report)) { 
        
               const parentReport = lodashGet(allReports, [`${ONYXKEYS.COLLECTION.REPORT}${report.parentReportID}`]); 
        
               return getRootReportAndWorkspaceName(parentReport); 
        
           }

What alternative solutions did you explore? (Optional)

@kevinksullivan

@kevinksullivan Whoops! This issue is 2 days overdue. Let's get this updated quick!

Job added to Upwork: https://www.upwork.com/jobs/~014565dfd91b80271a

@parasharrajat

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

@parasharrajat

Current assignee @parasharrajat is eligible for the Internal assigner, not assigning anyone new.

@JmillsExpensify

@JmillsExpensify Any comments on #27986 (comment)

@kevinksullivan

@kevinksullivan, @parasharrajat Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@JmillsExpensify

@JmillsExpensify @kevinksullivan Do you have any comments on #27986 (comment)?

@chiragsalian

Agree with @chiragsalian here

Navigation Menu

Repository navigation

[$500] `chat` thread report header is incorrectly showing the "root" report in second line rather than the "parent" report. #27986

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

22 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (isChildReport(report) && !isMoneyRequestReport(report) && !isTaskReport(report)) {
	const parentReport = lodashGet(allReports, [`${ONYXKEYS.COLLECTION.REPORT}${report.parentReportID}`]);
	return getRootReportAndWorkspaceName(parentReport);
	}

[$500] chat thread report header is incorrectly showing the "root" report in second line rather than the "parent" report. #27986

Description

Activity

melvin-bot commented on Sep 22, 2023

melvin-bot commented on Sep 22, 2023

Bug0 Triage Checklist (Main S/O)

JmillsExpensify commented on Sep 22, 2023

dukenv0307 commented on Sep 22, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Sep 25, 2023

melvin-bot commented on Sep 26, 2023

melvin-bot commented on Sep 26, 2023

22 remaining items

melvin-bot commented on Oct 20, 2023

parasharrajat commented on Oct 21, 2023

melvin-bot commented on Oct 24, 2023

parasharrajat commented on Oct 24, 2023

kevinksullivan commented on Oct 27, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

[$500] `chat` thread report header is incorrectly showing the "root" report in second line rather than the "parent" report. #27986