[$500] Web - Private Note - Input is not focused after reloading the page.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any Report => Report Details => Private Notes.
2. Click My Notes => Reload the page.
3. Notice that the Input is not focused.

Expected Result:

Input should be focused after reloading the page.

Actual Result:

Input is not focused after reloading the page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.71.4
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-17.at.11.27.44.mov

Recording.4575.mp4

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694924854779879

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012866eed98442daeb
• Upwork Job ID: 1703807251460964352
• Last Price Increase: 2023-10-02

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Dev: Web - Private notes - Delay in displaying the "Notes" field and "Save" button when refreshing the Private

What is the root cause of that problem?

We focus the input when the onEntryTransitionEnd is triggered. But when we reload the page, sometimes this is not triggered.

App/src/pages/PrivateNotes/PrivateNotesEditPage.js

Line 81 in c77814f

onEntryTransitionEnd={() => focusAndUpdateMultilineInputRange(privateNotesInput.current)}

What changes do you think we should make in order to solve the problem?

We should use useFocusEffect and InteractionManager.runAfterInteractions in the same way we operate in EditRequestAmountPage to make the input is always focused when the page is focused.

useFocusEffect(
    useCallback(() => {
        InteractionManager.runAfterInteractions(() => {
            focusAndUpdateMultilineInputRange(privateNotesInput.current);
        })
    }, []),
);

What alternative solutions did you explore? (Optional)

NA

Result

Screencast.from.17-09-2023.21.17.33.webm

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012866eed98442daeb

[melvin-bot]

Triggered auto assignment to @jliexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[kbecciv]

Proposal by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694924854779879

Proposal

Please re-state the problem that we are trying to solve in this issue.

Private Note - Input is not focused after reloading the page.

What is the root cause of that problem?

We're focusing the input after transition end, however while the page is reloading, privateNotesInput.current will be null first focusAndUpdateMultilineInputRange will early return.

App/src/pages/PrivateNotes/PrivateNotesEditPage.js

Line 81 in c77814f

onEntryTransitionEnd={() => focusAndUpdateMultilineInputRange(privateNotesInput.current)}

What changes do you think we should make in order to solve the problem?

Incase privateNotesInput is set yet and screen did end transition, we should focus the Input. So we should update the TextInput's ref as below:

    ref={(el) => {
        if (!el) {
            return;
        }
        if (!privateNotesInput.current && didScreenTransitionEnd) {
            focusAndUpdateMultilineInputRange(el);
        }
        privateNotesInput.current = el;
    }}

What alternative solutions did you explore? (Optional)

N/A