[HOLD for payment 2023-10-02] [$500] Web - Private Notes - Header is blur while the page is loading.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any report.
2. Click on the Report Details => Private Notes.
3. Verify that the Header is blur while the page is loading.

Expected Result:

The header should be clearly visible while the page is loading

Actual Result:

he header is blur while the page is loading.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.71.4
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-17.at.09.52.42.mov

Recording.4568.mp4

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694919130569099

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fa74e845c90b0078
• Upwork Job ID: 1703786341303091200
• Last Price Increase: 2023-09-18
• Automatic offers:
• jjcoffee | Reviewer | 26790081
• hungvu193 | Contributor | 26790083
• hungvu193 | Reporter | 26790085

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fa74e845c90b0078

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @anmurali (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[kbecciv]

Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694919130569099

Proposal

Please re-state the problem that we are trying to solve in this issue.

Private Notes - Header is blur while the page is loading which make it inconsistency with other pages that have loading.

What is the root cause of that problem?

We're using FullScreenLoadingIndicator while the page is loading here, since it use StyleSheet.absoluteFillObject which caused the issue.

App/src/pages/PrivateNotes/PrivateNotesListPage.js

Lines 131 to 133 in c77814f

	{report.isLoadingPrivateNotes && _.isEmpty(lodashGet(report, 'privateNotes', {})) ? (
	<FullScreenLoadingIndicator />
	) : (

What changes do you think we should make in order to solve the problem?

We should add style style={[styles.flex1, styles.pRelative]} for our FullScreenLoadingIndicator.

What alternative solutions did you explore? (Optional)

Incase we didn't want to show the header while loading, we can make FullScreenLoadingIndicator as a return early:

if (report.isLoadingPrivateNotes && _.isEmpty(lodashGet(report, 'privateNotes', {}))) {
  return  <FullScreenLoadingIndicator />;
}

return (
....
);

[PiyushChandra17]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Private Notes - Header is blur while the page is loading

What is the root cause of that problem?

We are using <FullScreenLoadingIndicator /> while the Private Notes page is loading, and it's styling is causing delays in rendering the header ie. StyleSheet.absoluteFillObject

App/src/pages/PrivateNotes/PrivateNotesListPage.js

Lines 131 to 135 in 6be8fca

	{report.isLoadingPrivateNotes && _.isEmpty(lodashGet(report, 'privateNotes', {})) ? (
	<FullScreenLoadingIndicator />
	) : (
	_.map(privateNotes, (item, index) => getMenuItem(item, index))
	)}

What changes do you think we should make in order to solve the problem?

We need to remove StyleSheet.absoluteFillObject and add styles.flex1 here:

App/src/components/FullscreenLoadingIndicator.js

Line 20 in 6be8fca

<View style={[StyleSheet.absoluteFillObject, styles.fullScreenLoading, ...additionalStyles]}>

What alternative solutions did you explore? (Optional)

NA

Result:

Screen.Recording.2023-09-18.at.10.27.28.PM.mov