[C+ Checklist Needs Completion] [$500] Web - App does not close Hmm its not here page on selecting current report from search

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any report
3. Trigger full page Hmm its not here page by visiting settings->workspace->any workspace->settings, copy the URL, remove 's' from the end and visit it.
4. Open search page by CTRL+K
5. Click on same report as opened in step 2
6. Observe that app still displays Full page 'Hmm its not here' page instead of report

Expected Result:

App should close Full page 'Hmm its not here' page on selecting any report from search

Actual Result:

App does not close Full page 'Hmm its not here' page on selecting same report as opened in background from search

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.70.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Hmm.its.not.here.full.page.not.closed.mp4

Recording.4524.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694765722471659

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ba78cc3a004601db
• Upwork Job ID: 1703071612120547328
• Last Price Increase: 2023-10-07
• Automatic offers:
• fedirjh | Reviewer | 27150714
• s-alves10 | Contributor | 27150719
• dhanashree-sawant | Reporter | 27150722

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ba78cc3a004601db

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @lschurr (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[abdel-h66]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - App does not close Hmm its not here page on selecting current report from search

What is the root cause of that problem?

When the serach is opened on the current report. and the current report is clicked We are just dissmissing the Search modal which makes sense because the report is already open.

What changes do you think we should make in order to solve the problem?

When the not found page appears, we have the last route name equal to NAVIGATORS.RIGHT_MODAL_NAVIGATOR

App/src/libs/Navigation/Navigation.js

Line 156 in 76c1559

function dismissModal(targetReportID) {

We can then add a check when the getTopmostReportId is the current report and also when the last route is NAVIGATORS.RIGHT_MODAL_NAVIGATOR this will handle this specific case only and will keep the rest of the behavior intact.

case SCREENS.REPORT_ATTACHMENTS:
            // if the
            if(targetReportID === getTopmostReportId(rootState) && lastRoute === NAVIGATORS.RIGHT_MODAL_NAVIGATOR) {
                navigationRef.current.dispatch({...StackActions.pop(2), target: rootState.key});
                return
            }
            // if we are not in the target report, we need to navigate to it after dismissing the modal
            if (targetReportID && targetReportID !== getTopmostReportId(rootState)) {
                const state = getStateFromPath(ROUTES.getReportRoute(targetReportID));
                const action = getActionFromState(state, linkingConfig.config);
                action.type = 'REPLACE';
                navigationRef.current.dispatch(action);
            }  else {
                    navigationRef.current.dispatch({...StackActions.pop(), target: rootState.key});
            }
            break;

Notice the use of StackActions.pop(2) instead of StackActions.pop() to make sure we go back twice to reach the previously opened report route.

The dismissModal function code can be improved but i'm new to the codebase and can't make such big changes and double check all the others cases 😄

issue-27580-proposal.mp4

What alternative solutions did you explore? (Optional)

N/A

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App doesn't close not-found page when navigating to the not-found page and navigating back to the current report from search

What is the root cause of that problem?

If user goes to the not-found page, the navigation stack has 3 navigators: Home, CentralPanNavigator(report), not-found.
If the user opens the search report modal, the navigation stack has 4, RightModalNavigator is added to the end

App/src/libs/Navigation/Navigation.js

Lines 167 to 175 in 76c1559

	if (targetReportID && targetReportID !== getTopmostReportId(rootState)) {
	const state = getStateFromPath(ROUTES.getReportRoute(targetReportID));
	const action = getActionFromState(state, linkingConfig.config);
	action.type = 'REPLACE';
	navigationRef.current.dispatch(action);
	} else {
	navigationRef.current.dispatch({...StackActions.pop(), target: rootState.key});
	}

In this case, targetReportID is the same as top-most reportID and so we pop the navigation stack once in line 174. That's why not-found page appears(not closed)

This is the root cause

What changes do you think we should make in order to solve the problem?

We're assuming that we can go to the report by popping once from the RightModalNavigator. This is wrong. We need to generalize this

We can fix this issue by popping to central navigator

            if (targetReportID && targetReportID !== getTopmostReportId(rootState)) {
                const state = getStateFromPath(ROUTES.getReportRoute(targetReportID));

                const action = getActionFromState(state, linkingConfig.config);
                action.type = 'REPLACE';
                navigationRef.current.dispatch(action);
            } else if (targetReportID && _.some(rootState.routes, route => route.name === SCREENS.NOT_FOUND)) {
                const lastRouteIndex = rootState.routes.length - 1;
                const centralRouteIndex = _.findLastIndex(rootState.routes, route => route.name === NAVIGATORS.CENTRAL_PANE_NAVIGATOR);
                navigationRef.current.dispatch({...StackActions.pop(lastRouteIndex - centralRouteIndex), target: rootState.key});
            } else {
                navigationRef.current.dispatch({...StackActions.pop(), target: rootState.key});
            }

This works fine

Result

27580.mp4

What alternative solutions did you explore? (Optional)