[HOLD for payment 2023-09-27] Web - search field or new group field remain focused after CTRL + K, CTRL + J or CTRL + SHIFT + K, CTRL + J

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the website
2. Click CTRL + K or CTRL + SHIFT + K
3. Click CTRL + J
4. Observe the search or new group field which is focused

Expected Result:

The search or new group field should not be focused since the keyboard shortcut modal is over the search RHN

Actual Result:

The search or new group field is focused and we can type when the keyboard shortcut is over the search or new group RHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.70.5
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screenshare.-.2023-09-15.1_53_42.AM.mp4

Recording.4487.mp4

Expensify/Expensify Issue URL:
Issue reported by: @misgana96
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694731952884149

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @nkuoch (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[nkuoch]

Probably not a deploy blocker, but definitely a regression (happening on staging but not production) - trying to find the culprit

[situchan]

@nkuoch I confirmed that the regression came from #24316. Shall we revert this?

[nkuoch]

Yes, as the original fix isn't fixing anything major, let's revert and ask them to redo with the new bug in mind

[situchan]

I can raise PR if you want.

[situchan]

I agree to revert that PR. It also fixes another deploy blocker - #27519.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.