[HOLD for payment 2023-10-09] [$500] [Distance] - Ability to request money without filling start and finish points

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Request money -> distance
2. Change /distance in the URL to /participants
3. Choose a workspace then click request

Expected Result:

The app should redirect the user to https://staging.new.expensify.com/request/new/distance

Actual Result:

The app allows users to request money

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.69.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

participants-bug.webm

Recording.4449.mp4

Expensify/Expensify Issue URL:
Issue reported by: @hichamcc
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694429194889109

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bf360a8a0ff38420
• Upwork Job ID: 1702018479558987776
• Last Price Increase: 2023-09-20
• Automatic offers:
• DylanDylann | Contributor | 26773601

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

[Distance] Ability to request money without filling start and finish points

What is the root cause of that problem?

We don't allow user to back to the first step if the request is a distance request

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js

Line 66 in 4d104f5

if (!isDistanceRequest && props.iou.id) {

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js

Line 78 in 4d104f5

if (!isDistanceRequest && ((props.iou.amount === 0 && !props.iou.receiptPath) || shouldReset)) {

What changes do you think we should make in order to solve the problem?

We should remove the check !isDistanceRequest to make user can reset to the first step

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01bf360a8a0ff38420

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @tjferriss (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Ability to request money without filling start and finish points

What is the root cause of that problem?

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js

Lines 79 to 81 in 7deca7a

	if (!isDistanceRequest && ((props.iou.amount === 0 && !props.iou.receiptPath) || shouldReset)) {
	navigateBack(true);
	}

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js

Lines 67 to 69 in 7deca7a

	if (!isDistanceRequest && props.iou.id) {
	navigateBack(true);
	}

Let's see this code, we only navigate back if itn't distance request. It seems that we want to prevent user come back in distance request

What changes do you think we should make in order to solve the problem?

We should update the logic to allow users:

1. Coming back if it isn't distance request
2. Coming back if it is distance request and there are no waypoint (no route)

To do that we can get waypoint from transaction like this

const transaction = TransactionUtils.getTransaction(props.iou.transactionID);
const isEmptyWaypoint = _.isEmpty(lodashGet(transaction, 'comment.waypoint.waypoint0', {}))

and in here

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js

Lines 79 to 81 in 7deca7a

	if (!isDistanceRequest && ((props.iou.amount === 0 && !props.iou.receiptPath) || shouldReset)) {
	navigateBack(true);
	}

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js

Lines 67 to 69 in 7deca7a

	if (!isDistanceRequest && props.iou.id) {
	navigateBack(true);
	}

update the condition to

(!isDistanceRequest || (isDistanceRequest && isEmptyWaypoint))

instead of only !isDistanceRequest

What alternative solutions did you explore? (Optional)

Same like the main solution but we can use isEmptyRoute instead of isEmptyWaypoint

const isEmptyWaypoint = _.isEmpty(lodashGet(transaction, 'comment.routes', {}))