[HOLD for payment 2023-10-13] [$500] [Distance] - App does not refocus on address field on delete and cancel

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Click plus and open request money
3. Click on distance
4. Click on Add stop
5. Open newly created stop
6. Click on 3 dots and click on delete waypoint
7. Click cancel in confirmation popup
8. Observe that address field is not focused

Expected Result:

App should focus back on address field on delete and cancel as we do for normal report messages

Actual Result:

App does not focus back on address field on delete and cancel

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.67.2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

no.focus.back.on.delete.cancel.address.field.mp4

Recording.4396.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694111463191149

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0115c7c503e332eb0f
• Upwork Job ID: 1701291764562169856
• Last Price Increase: 2023-09-11
• Automatic offers:
• Krishna2323 | Contributor | 26724773

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0115c7c503e332eb0f

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @greg-schroeder (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App does not refocus on address field on delete and cancel.

What is the root cause of that problem?

We are not refocusing on input when modal is closed.

What changes do you think we should make in order to solve the problem?

We need to focus on the input using input ref when waypoint delete modal is closed by passing onModalHide prop to ConfirmModal.

onModalHide={() => {
    InteractionManager.runAfterInteractions(() => {
        if (!textInput.current) return;
        textInput.current.focus();
    });
}}

App/src/pages/iou/WaypointEditor.js

Lines 183 to 191 in 9d8518a

	<ConfirmModal
	title={translate('distance.deleteWaypoint')}
	isVisible={isDeleteStopModalOpen}
	onConfirm={deleteStopAndHideModal}
	onCancel={() => setIsDeleteStopModalOpen(false)}
	prompt={translate('distance.deleteWaypointConfirmation')}
	confirmText={translate('common.delete')}
	cancelText={translate('common.cancel')}
	danger

Result

[yh-0218]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App does not refocus on address field on delete and cancel.

What is the root cause of that problem?

We are not focusing on input when modal is closed.

What changes do you think we should make in order to solve the problem?

We can call this function when close modal.

    const onModalHide = useCallback(() => {
        setIsDeleteStopModalOpen(false)
        if (textInput === null || textInput.current === null) {
            return;
        }
        const timeout = _.delay(() => {
            textInput.current.focus();
        }, 500);
        return () => clearTimeout(timeout);
    }, [textInput]);

App/src/pages/iou/WaypointEditor.js

Lines 183 to 191 in 9d8518a

	<ConfirmModal
	title={translate('distance.deleteWaypoint')}
	isVisible={isDeleteStopModalOpen}
	onConfirm={deleteStopAndHideModal}
	onCancel={() => setIsDeleteStopModalOpen(false)}
	prompt={translate('distance.deleteWaypointConfirmation')}
	confirmText={translate('common.delete')}
	cancelText={translate('common.cancel')}
	danger

What alternative solutions did you explore? (Optional)