[HOLD for payment 2023-10-09] HIGH: LHN logic is broken for paid reports

Correct logic as follows:

policyExpenseChat (member view)

First line: %workspaceName% (note: name depends on who’s looking at it, this is the member case)
Second line: latest message in the workspace chat. We a report has just paid paid, that's %workspaceName% paid %amount%

Report (member & admin)

First line: report name (e.g. %workspaceName% paid %amount%)
Second line: latest message, (e.g. %userDisplayName% paid %amount%

At the moment the policyExpenseChat is incorrectly showing the second line from the report (e.g. Niki paid...) instead of what should should actually be the second line for the policyExpenseChat.

Example

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0159fb834042f1a338
Upwork Job ID: 1698698179177246720
Last Price Increase: 2023-09-04

Job added to Upwork: https://www.upwork.com/jobs/~0159fb834042f1a338

@adelekennedy

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@mananjadhav

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mananjadhav (Internal)

Taking this as part of waves

@JmillsExpensify

@JmillsExpensify, @mananjadhav 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

Adding this to wave4 so that we ensure it gets picked up.

And yeah you are correct, in the LHN we should show the Workspace paid,

You're talking about the title of the expenseReport in the LHN, yeah?

Both of these

Ah, so no.. the preview is of the report action added to the report and should come from whichever user took the action.

When someone pays an expenseReport:

The reportAction added to the report comes from the reimburser who paid
The LHN title updates to "%workspaceName% paid %reportTotal%"
The LHN preview shows (1).

I.e

Report Action

Tom Rhys Jones 11:58am
paid $50.00 elsewhere

LHN

Duraflame paid $50.00
Tom: paid $50.00 elsewhere

Ah I missed it with the workspace chat preview

Then there its correctly saying the %workspaceName% paid this

Yup, the workspace chat preview is correct because it's a preview of the report which title updated in (2) above.

@mountiny

Shall we create a fresh issue then? For what it's worth, I like this idea from @mountiny:

@koko57 we could try to abstract away some of the logic to determine to LHN preview messages and then create unit tests for that method based on various scenarios of the reports, would that be feasible?

P.S. Regression test has been added.

@mananjadhav

$500 payment approved for @mananjadhav based on this summary.

@JmillsExpensify

@JmillsExpensify @mountiny should I start working on this one? 🙂 Will a new ticket be created?

New issue would be helpful and I can help with the review.

@trjExpensify

Yes @trjExpensify would you be able to create a new one for this? You will be the best in defining exactly what needs to be done

@koko57

@koko57 can you write a message on the new issue so I can assign you? Thanks! #30042

Thanks this can be closed then ❤️

Navigation Menu

Repository navigation

[HOLD for payment 2023-10-09] HIGH: LHN logic is broken for paid reports #26669

Bug0 Triage Checklist (Main S/O)

73 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-10-09] HIGH: LHN logic is broken for paid reports #26669

Description

Activity

melvin-bot commented on Sep 4, 2023

melvin-bot commented on Sep 4, 2023

melvin-bot commented on Sep 4, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Sep 4, 2023

JmillsExpensify commented on Sep 4, 2023

melvin-bot commented on Sep 12, 2023

JmillsExpensify commented on Sep 13, 2023

73 remaining items

trjExpensify commented on Oct 16, 2023

mountiny commented on Oct 16, 2023

trjExpensify commented on Oct 16, 2023

mountiny commented on Oct 16, 2023

trjExpensify commented on Oct 16, 2023

JmillsExpensify commented on Oct 16, 2023

JmillsExpensify commented on Oct 16, 2023

JmillsExpensify commented on Oct 16, 2023

koko57 commented on Oct 18, 2023

mananjadhav commented on Oct 18, 2023

mountiny commented on Oct 18, 2023

trjExpensify commented on Oct 20, 2023

mountiny commented on Oct 20, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions