[$500] Web - Report Preview in Report Screen shows up even after deletion of Money Request

@rojiphil

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Use FAB on a ChatReport and generate money request
Click on IOUReport to show the IOUReport
Use menu to delete the Money Request
Come back to ChatReport of Step 1
Reload the page.

Expected Result:

Report Previous should not show up for a deleted Money Request

Actual Result:

Report Preview shows up for a deleted Money Request

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.62.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

deletemrfails.mp4

Recording.4231.mp4

Expensify/Expensify Issue URL:
Issue reported by: @rojiphil
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693399731169779

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~013c7ff8faa3f9e5a6
Upwork Job ID: 1704099592925270016
Last Price Increase: 2023-09-26

@muttmuure

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Report Preview in Report Screen shows up even after deletion of Money Request

What is the root cause of that problem?

The problem occurs because we are not clearing the Report Preview on the deletion of the IOU Report. . Further, pendingAction is not set for ReportPreview for Offline support.

What changes do you think we should make in order to solve the problem?

This can be solved by clearing up the Report Preview when IOU Report is deleted at this location within successData of deleteMoneyRequest method

The changes can be as follows:

        ...(shouldDeleteIOUReport
            ? [
                {
                    onyxMethod: Onyx.METHOD.MERGE,
                    key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${chatReport.reportID}`,
                    value: {
                        [reportPreviewAction.reportActionID]: {
                            pendingAction: null,
                            message: [
                                {
                                    type: 'COMMENT',
                                    html: '',
                                    text: '',
                                    isEdited: true,
                                },
                            ],
                            errors: null,
                        },
                    },
                },
              ]
            : []),

In addition, we need to support offline mode. For this, we can add the pendingAction to DELETE as follows here

    let updatedReportPreviewAction = {...reportPreviewAction};
    if(shouldDeleteIOUReport)
    {
        updatedReportPreviewAction.pendingAction = CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE;
        updatedReportPreviewAction.errors = null;
    }

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

Report preview in report page shows again even after money request is deleted

What is the root cause of that problem?

When we delete a money request, deleteMoneyRequest function is called.
As you can see, if shouldDeleteIOUReport is true, we optimistically merge the report preview action with null

App/src/libs/actions/IOU.js

Lines 1183 to 1189 in d971190

    
           { 
        
               onyxMethod: Onyx.METHOD.MERGE, 
        
               key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${chatReport.reportID}`, 
        
               value: { 
        
                   [reportPreviewAction.reportActionID]: updatedReportPreviewAction, 
        
               }, 
        
           },

And the deleteMoneyRequest API returns {[reportPreviewActionID]: null}, too.
The problem is in Onyx.merge

Please check the code here

We remove the keys with null value in modifiedData and call Storage.mergeItem. This means null values are not updated in storage though they are updated in memory. This bug looks like was introduced by this PR

This is the root cause of this issue

What changes do you think we should make in order to solve the problem?

In Onyx.merge function, we merge the changes with existing data and remove all keys with null values, we have to call Storage.setItem instead of Storage.mergeItem

This works as expected

Result

26627.mp4

What alternative solutions did you explore? (Optional)

@hannojg

Calling Storage.setItem instead of Storage.mergeItem is definitely not what we want to do here, because we added JSON_PATCH functionality for SQLite on native here.

I just discovered the potential problem. I think it’s related to the idb-keyval PR by @hannojg. The problem is, that before this PR, on web we just set the modified data with the nullish keys removed already. After this PR, on web we’re using yet another merge funcationality, which will not drop the nullish keys, because the modified data with the removed nullish keys will be merged.

I’m gonna open a PR, which fixes this.

I hope you open the PR asap. I think this bug may cause several issues

@muttmuure

@muttmuure Still overdue 6 days?! Let's take care of this!

I hope you open the PR asap. I think this bug may cause several issues

@s-alves10 just created a PR in Onyx that fixes this issue: Expensify/react-native-onyx#333

@muttmuure

@muttmuure 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@muttmuure

@muttmuure 10 days overdue. I'm getting more depressed than Marvin.

@muttmuure

@muttmuure this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@allroundexperts

Current assignee @allroundexperts is eligible for the Internal assigner, not assigning anyone new.

@allroundexperts

@allroundexperts, @muttmuure 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

No proposals, going to come back in a week and see if this is reproducible

@muttmuure

@muttmuure
As I understand, the PR in this comment was supposed to resolve this issue.
@chrispader @s-alves10 can confirm

Issue not reproducible during KI retests. (First week)

Issue not reproducible during KI retests. (Second week)

@allroundexperts

@allroundexperts @muttmuure
Can we not close this issue if the issue is fixed already?
Also, there are other issues dependent on the resolution of this one. Closing this would help us move further on the other issues.

@rojiphil

This hasn't been reproducible for two weeks [following this PR] (#26627 (comment)) - closing. Thank you @rojiphil !

@miljakljajic

@miljakljajic @muttmuure
Don't I qualify for a reporter bonus here as I had reported the bug?

Navigation Menu

Repository navigation

[$500] Web - Report Preview in Report Screen shows up even after deletion of Money Request #26627

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

22 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${chatReport.reportID}`,
	value: {
	[reportPreviewAction.reportActionID]: updatedReportPreviewAction,
	},
	},

[$500] Web - Report Preview in Report Screen shows up even after deletion of Money Request #26627

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Sep 3, 2023

melvin-bot commented on Sep 3, 2023

Bug0 Triage Checklist (Main S/O)

rojiphil commented on Sep 4, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

dummy-1111 commented on Sep 4, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

chrispader commented on Sep 5, 2023

dummy-1111 commented on Sep 5, 2023

melvin-bot commented on Sep 11, 2023

chrispader commented on Sep 11, 2023

melvin-bot commented on Sep 13, 2023

melvin-bot commented on Sep 15, 2023

melvin-bot commented on Sep 17, 2023

22 remaining items

melvin-bot commented on Oct 1, 2023

melvin-bot commented on Oct 3, 2023

muttmuure commented on Oct 3, 2023

rojiphil commented on Oct 3, 2023

mvtglobally commented on Oct 5, 2023

mvtglobally commented on Oct 12, 2023

rojiphil commented on Oct 19, 2023

miljakljajic commented on Oct 19, 2023

rojiphil commented on Oct 25, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions