[HOLD for payment 2023-10-05] [$500] Web - Task avatar not correct when sharing it in workspace chat

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Create a new workspace.
2. Create a new task
3. Select the share destination as the workspace chat of the current account.

Expected Result:

The workspace icon at the bottom right should be correct

Actual Result:

The workspace icon at the bottom right is invalid and only gets updated after sending a message in the task report.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.62.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-27.at.7.40.40.PM.mov

Recording.4195.mp4

Expensify/Expensify Issue URL:
Issue reported by: @esh-g
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693145642005219

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e42a684a1fd73bba
• Upwork Job ID: 1699077008312233984
• Last Price Increase: 2023-09-19
• Automatic offers:
• Ollyws | Reviewer | 26767060
• esh-g | Contributor | 26767062
• esh-g | Reporter | 26767064

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kbecciv]

Proposal by: @esh-g
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693145642005219

Proposal

by @esh-g

Please re-state the problem we are trying to solve

Unavailable workspace avatar is seen as subscript of a task that is shared in the ownPolicyExpenseChat

What is the root cause of this?

The root cause is that the taskReport when created optimistically, does not possess a policyID but it is a child of a policyExpenseChat so the avatar of workspace is shown but since policyID is undefined, the avatar shown is of Unavailable Workspace starting with U.
We can see in the following snippet that we are specifically handling avatar cases for WorkspaceTaskReport:

App/src/libs/ReportUtils.js

Lines 981 to 984 in 64ff471

	if (isWorkspaceTaskReport(report)) {
	const workspaceIcon = getWorkspaceIcon(report, policy);
	return [ownerIcon, workspaceIcon];
	}

What changes should be made in-order to fix this?

We should add policyID of the parent report while building optimistic data for taskReport here:

App/src/libs/ReportUtils.js

Lines 2483 to 2496 in 64ff471

	function buildOptimisticTaskReport(ownerAccountID, assigneeAccountID = 0, parentReportID, title, description) {
	return {
	reportID: generateReportID(),
	reportName: title,
	description,
	ownerAccountID,
	participantAccountIDs: assigneeAccountID && assigneeAccountID !== ownerAccountID ? [assigneeAccountID] : [],
	managerID: assigneeAccountID,
	type: CONST.REPORT.TYPE.TASK,
	parentReportID,
	stateNum: CONST.REPORT.STATE_NUM.OPEN,
	statusNum: CONST.REPORT.STATUS.OPEN,
	};
	}

And this can be done by adding this line in the body of the function:

const policyID = lodashGet(allReports[`${ONYXKEYS.COLLECTION.REPORT}${parentReportID}`], 'policyID', CONST.POLICY.OWNER_EMAIL_FAKE);

Then we can just return policyID as well.
PS: Here I'm using CONST.POLICY.OWNER_EMAIL_FAKE instead of CONST.POLICY.OWNER_ACCOUNT_ID_FAKE even though it says policyID because I saw this being used in other places as well.

What other alternatives did you explore? (Optional)

• We can have the buildOptimisticTaskReport() function accept the policyID as an argument that can be passed while creating the task.

[bfitzexpensify]

Sending this external

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e42a684a1fd73bba

[melvin-bot]

Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.