[HOLD for payment 2023-10-23] [$500] [Android] User isn't prompted for Camera permission via the native Modal

[Julesssss]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Ensure the Camera permission is denied
2. Tap FAB > Request money > Scan
3. Click the 'Give Permission' button

Expected Result:

• We should show the native Android request permission modal
• Given that the user has tapped give permission, I don't think an initial 'We are going to ask you for permission' modal is required (it would in other cases in order to prevent the OS from blocking future permission requests)
• The solution should work exactly the same as it does for native Android/iOS apps

Actual Result:

I am deep linked directly to the top level generic app settings page, and must manually tap 'Permissions > Camera'

Workaround:

I must manually tap 'Permissions > Camera'. Some users might not know how to do this.

screen-20230901-162220.mp4

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.61-1
Reproducible in staging?: yes
Reproducible in production?: yes (once deployed)
Issue reported by: @Julesssss
Slack conversation: N/A

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f5f4967e2e242138
• Upwork Job ID: 1698645305652506624
• Last Price Increase: 2023-09-04
• Automatic offers:
• ntdiary | Reviewer | 26488566
• ishpaul777 | Contributor | 26488567
• zoontek | Contributor | 26980722

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Julesssss]

This is more of a feature improvement than a bug

[ishpaul777]

@Julesssss what if we directly request permission with native pop up on click of button, if permission "denied" or "restricted" then show native alert modal similar to flow of launching camera while adding attachements.
ref - https://github.com/Expensify/App/blob/main/src/components/AttachmentPicker/launchCamera.android.js#L14C5-L23C11

Screeshot

[akinwale]

@Julesssss It's not possible to deep-link directly to the Camera settings page. The best option is to open the App settings page which is what is currently happening.

Also, the current implementation seems weird. I would assume that the app should try to request for the camera permission at least once (which shows a dialog to grant or deny the request), before making the user have to navigate to the device app settings.

[sakluger]

@Julesssss do you need me to triage this issue or anything, or are you going to mostly manage the issue and I can just handle any contributor payments that come up?

[Julesssss]

It's not possible to deep-link directly to the Camera settings page.

Ah, right. We can deep link directly to the location permission so I assumed it worked for all permissions. Oh well.

I would assume that the app should try to request for the camera permission at least once (which shows a dialog to grant or deny the request), before making the user have to navigate to the device app settings.

100% agree with this and ishpaul777's comment. That's what we should be doing on native Android.

@sakluger I'll update the description and will manage it.