[Distance] IOU Distance - Recent list disappears after clearing address field, leaving a big space

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #25990

Action Performed:

1. Go to staging.new.expensify.com
2. Go to + > Request money > Distance
3. Click Start > Use current location
4. Go to Start again
5. Highlight the address field
6. Clear the input

Expected Result:

The recent address list will not disappear

Actual Result:

The recent address list disappears, leaving a huge space between the address field and Use current location button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.61-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6184883_bandicam_2023-09-01_17-41-32-773.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @grgia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On clearing the text list shows empty space

What is the root cause of that problem?

On input change within AddressSearch we set the displayListViewBorder to false when the text is empty.

App/src/components/AddressSearch/index.js

Lines 336 to 339 in 5db2445

	// If the text is empty, we set displayListViewBorder to false to prevent UI flickering
	if (_.isEmpty(text)) {
	setDisplayListViewBorder(false);
	}

Based on displayListViewBorder value we are applying a style to scale down to 0 which is causing the issue.

App/src/components/AddressSearch/index.js

Line 346 in 5db2445

listView: [StyleUtils.getGoogleListViewStyle(displayListViewBorder), styles.overflowAuto, styles.borderLeft, styles.borderRight],

App/src/styles/StyleUtils.js

Lines 1190 to 1192 in 5db2445

	return {
	transform: [{scale: 0}],
	};

What changes do you think we should make in order to solve the problem?

When predefinedPlaces is available we don't need to scale to 0, for that we need to update the condition

if (_.isEmpty(text) && _.isEmpty(props.predefinedPlaces)) {

Result

Screen.Recording.2023-09-01.at.21.25.21.mov

[huzaifa-99]

I will be fixing this with a new PR (taking changes from #25990)

cc: @hayata-suenaga @narefyev91

[Pujan92]

@huzaifa-99 I think this issue is not due to your PR as we are passing predefinedPlaces earlier too.
cc: @grgia

[huzaifa-99]

@Pujan92 Yes its directly not related to my changes. But i am not sure if we should treat it as regression or bug here since this issue was not visible before my changes.

cc: @hayata-suenaga @narefyev91

[Pujan92]

It exists from this PR, but at that moment we don't have any other content below that so not easily caught. Since you added the current location option below that which highlights the issue.

After checkout the mentioned PR commit

Screen.Recording.2023-09-01.at.21.48.40.mov

[luacmartins]

We reverted the offending PR. Removing the blocker label.