Repository navigation
[HOLD for payment 2023-09-08] [HOLD for payment 2023-09-07] [$500] Web - Sign in - "Abracadabra, you are signed in!" page is displayed in chat conversation #26417
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Log out of the account
- Enter the email on the email field and continue
- Navigate to the email inbox and look for the magic link email
- Change the link to staging if needed
- Open a new tab and paste the link in the URL
- Verify an "Abracadabra, you are signed in!" page is displayed in entire page
Expected Result:
"Abracadabra, you are signed in!" page is displayed in entire page
Actual Result:
"Abracadabra, you are signed in!" page is displayed in chat conversation
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.3.60.1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Recording.4129.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Automation Team
Slack conversation:
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01af75b23e8aefa481
- Upwork Job ID: 1697320264137629696
- Last Price Increase: 2023-08-31
- Automatic offers:
- jjcoffee | Reviewer | 26440465
- situchan | Contributor | 26440466
Activity
kbecciv commentedon Aug 31, 2023
Team is not able to reproduce in Production.
Recording.4131.mp4
OSBotify commentedon Aug 31, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Aug 31, 2023
Triggered auto assignment to @arosiclair (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.GItGudRatio commentedon Aug 31, 2023
P.S: I'm available to create a PR right away within 30 mins.
Proposal
Please re-state the problem that we are trying to solve in this issue.
"Abracadabra, you are signed in!" page is displayed in chat conversation.
What is the root cause of that problem?
This is a regression from #22437. We do not pass the options to render the screen on the whole page, which ends up the page being displayed in the area for reports.
What changes do you think we should make in order to solve the problem?
We need to add
...screenOptions.fullScreenhere:App/src/libs/Navigation/AppNavigator/AuthScreens.js
Lines 242 to 245 in 2460704
What alternative solutions did you explore? (Optional)
N/A
GItGudRatio commentedon Aug 31, 2023
Note: My above mentioned proposal changes the design slightly. I don't think this is a bug issue but would still like @shawnborton's 🟢 on this:
Prod
After Patch
If required, we can change the design as well by creating a new option altogether in
getRootNavigatorScreenOptions.jsmountiny commentedon Aug 31, 2023
@GItGudRatio I think that is fine, can you please make the PR?
[-]Web - Sign in - "Abracadabra, you are signed in!" page is displayed in chat conversation[/-][+][$500] Web - Sign in - "Abracadabra, you are signed in!" page is displayed in chat conversation[/+]melvin-bot commentedon Aug 31, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01af75b23e8aefa481
30 remaining items
luacmartins commentedon Sep 11, 2023
I believe we're just missing payments
adelekennedy commentedon Sep 12, 2023
Payouts due:
Issue Reporter: N/A
Contributor: $500 @GItGudRatio (Upwork)
Contributor+: $500 @situchan (Upwork)
Eligible for 50% #urgency bonus? Y
Upwork job is here.
adelekennedy commentedon Sep 12, 2023
@GItGudRatio will you apply here?
GItGudRatio commentedon Sep 12, 2023
@adelekennedy applied, thank you!
luacmartins commentedon Sep 21, 2023
Still processing payments
situchan commentedon Oct 2, 2023
I think I haven't received 50% bonus.
@adelekennedy can you check please?
GItGudRatio commentedon Oct 2, 2023
Me too!
adelekennedy commentedon Oct 4, 2023
Yikes - sorry this is what happens when you try to clean up issues fast while ooo - adding the $250bonus for you both