[HOLD for payment 2023-10-09] [$500] Border appears for the User avatar on the Money request page header.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open any chat and request Money ( make sure it works by avoiding the bugs around the IOU feature Now ) and Open it, you could Open any existing money request message
2. Notice the avatars on the money request header
3. May be you will need to zoom in to notice it clearly

Expected Result:

The avatar shouldn't have any border.

• Or to be more accurate, The border color for avatar should match the background color, to be invisible and style the both participants avatar like we want

Actual Result:

The user avatar has a border.

• The avatar border has a different shade of green, creating a border effect. The border appears because we should give it a boder color that matches the background color to be invisible and gave us the style we want for both participants avatars. Like the avatars in money request message in the main chat.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.59-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.22-08-23.04_37_03.webm

Expensify/Expensify Issue URL:
Issue reported by: @Ahmed-Abdella
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692669808539929

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013384dd572fef261e
• Upwork Job ID: 1699883091268702208
• Last Price Increase: 2023-09-07
• Automatic offers:
• bernhardoj | Contributor | 26665036
• Ahmed-Abdella | Reporter | 26665037

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dummy-1111]

This looks like an intended behavior

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Border appears for the second user avatar on the money request page header

What is the root cause of that problem?

We have AvatarWithDisplayName component in HeaderWithBackButton of MoneyReportHeader

We're setting the second avatar style here in the AvatarWithDisplayName component

App/src/components/AvatarWithDisplayName.js

Line 115 in c20c387

secondAvatarStyle={[StyleUtils.getBackgroundAndBorderStyle(themeColors.highlightBG)]}

This is the root cause

What changes do you think we should make in order to solve the problem?

We need to change highlightBG to appBG in AvatarWithDisplayName component

        <MultipleAvatars
            icons={icons}
            size={props.size}
            secondAvatarStyle={[StyleUtils.getBackgroundAndBorderStyle(themeColors.appBG)]}
        />

This works fine

Note: We can add additional props for setting second avatar style in the AvatarWithDisplayName component

Result

What alternative solutions did you explore? (Optional)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The real issue is, that the avatar border style does not match the header background color.

What is the root cause of that problem?

The money report header uses AvatarWithDisplayName to show the avatar which will render MultipleAvatars. The second avatar style has a border color of highlightBG #07271F.

App/src/components/AvatarWithDisplayName.js

Lines 112 to 116 in c20c387

	<MultipleAvatars
	icons={icons}
	size={props.size}
	secondAvatarStyle={[StyleUtils.getBackgroundAndBorderStyle(themeColors.highlightBG)]}
	/>

However, the header has a transparent background which then shows the background of the report screen which is appBG #061B09. We can notice the color is different.

The avatar border color is introduced in #22467 and the reason the avatar border color is set to highlightBG is to match the background color of the old money report header.

What changes do you think we should make in order to solve the problem?

We have 2 options.

1. Change the color to appBG.
2. Remove the secondary avatar style as MultipleAvatar already has a default style with a color of componentBG which has the same value as appBG.

I prefer the 2nd option as we did this in HeaderView.

App/src/pages/home/HeaderView.js

Lines 177 to 182 in c20c387

	) : (
	<MultipleAvatars
	icons={icons}
	shouldShowTooltip={!isChatRoom || isChatThread}
	/>
	)}

[joekaufmanexpensify]

I agree there is a border, but not sure that this is actually a bug. Further, you can only really notice the border when significantly zoomed in, like this:

When you're at normal zoom, it just distinguishes between the two avatars, which makes me think this may be intended.

I'm inclined to do nothing here, but curious what @shawnborton thinks?

[bernhardoj]

@joekaufmanexpensify the border is indeed intended, but it should match the background color like it does on the LHN

[shawnborton]

Yeah, that border should match the background color. @grgia I think this was part of the avatar changes you made, are you able to follow up and fix this one quickly?

[joekaufmanexpensify]

Cool cool, sounds good.

[joekaufmanexpensify]

Not overdue