[HOLD for payment 2023-09-21] [HOLD for payment 2023-09-18] [$500] Expensify logo vs notification color mismatch

@avi-shek-jha

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

1 Login with user A on Android app (make sure notification is on for the app)
2 Login with user B on chrome browser
3 From User B on chrome, send a message to User A. This will trigger a notification.
4 Verify the color of the expensify logo is blue on the notification while the app has green

Expected Result:

Logo color should be consistent

Actual Result:

The notification has Expensify logo in Blue color while the actual app is in green

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: v1.3.58-3

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

vidma_recorder_19082023_144929.1.mp4

Screen.Recording.20230829.230756.Chrome.mp4

Expensify/Expensify Issue URL:

Issue reported by: @avi-shek-jha

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692481632188449

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01981452361d59e3c3
Upwork Job ID: 1696839765016084480
Last Price Increase: 2023-08-30
Automatic offers:

GItGudRatio | Contributor | 26427949
avi-shek-jha | Reporter | 26427950

@NicMendonca

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@Julesssss

@Julesssss thoughts on this one?

@shawnborton

Proposal

Please re-state the problem that we are trying to solve in this issue.

The notification has Expensify logo in Blue color while the actual app is in green

What is the root cause of that problem?

We set the background color of notification to be #2EAAE2, which is blue.

App/android/app/src/main/assets/airshipconfig.properties

Line 7 in 5b4dee8

notificationAccentColor = #2EAAE2

What changes do you think we should make in order to solve the problem?

Change the notificationAccentColor to the background used on the splash screen background #03D47C. @shawnborton can help with the hex code.

Result

What alternative solutions did you explore? (Optional)

N/A

@dannymcclain

Triggered auto assignment to @dannymcclain (Design), see these Stack Overflow questions for more details.

@GItGudRatio

Nice, @GItGudRatio shared the solution already 👍

The correct colour is #03D47C.

While we're modifying the icon bg colour, I'm wondering if we should also change the white notification icon to be dark to better match our app icon. The problem is that this is displayed at such a low resolution that it might not look great. I think typically apps use unique icons for the notification badge because of this... What do you think @shawnborton?

Job added to Upwork: https://www.upwork.com/jobs/~01981452361d59e3c3

@narefyev91

@narefyev91 bump on the BZ checklist!

The PR that introduced the bug has been identified. Link to the PR - it was a new request to change icon color
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug - N/A

@Julesssss

@Julesssss just to confirm - are we waiting until 09-21 for payment?

yeah, payment can occur now.

I am also eligible for reviewing 2nd PR?

@avi-shek-jha

reporter: @avi-shek-jha - $250
contributor: @GItGudRatio - $1500
c+: @narefyev91 (does not require payment): n/a
PR reviewer: @aimane-chnaif - $500

@aimane-chnaif please request payment in Expensify. Otherwise, please apply to the job if you require payment via Upwork

@avi-shek-jha @GItGudRatio you've both been paid

bump @narefyev9 on BZ checklist!

@aimane-chnaif

bump @narefyev9 on BZ checklist!

#26255 (comment)

@aimane-chnaif please request payment in Expensify. Otherwise, please apply to the job if you require payment via Upwork

@NicMendonca can you please send upwork offer?

@aimane-chnaif

@aimane-chnaif offer sent

ok everyone has been paid! 🎉

Navigation Menu

Repository navigation

[HOLD for payment 2023-09-21] [HOLD for payment 2023-09-18] [$500] Expensify logo vs notification color mismatch #26255

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result

What alternative solutions did you explore? (Optional)

70 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-09-21] [HOLD for payment 2023-09-18] [$500] Expensify logo vs notification color mismatch #26255

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Aug 29, 2023

melvin-bot commented on Aug 29, 2023

Bug0 Triage Checklist (Main S/O)

shawnborton commented on Aug 29, 2023

GItGudRatio commented on Aug 29, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result

What alternative solutions did you explore? (Optional)

melvin-bot commented on Aug 29, 2023

Julesssss commented on Aug 30, 2023

melvin-bot commented on Aug 30, 2023

70 remaining items

NicMendonca commented on Sep 20, 2023

narefyev91 commented on Sep 20, 2023

NicMendonca commented on Sep 21, 2023

Julesssss commented on Sep 22, 2023

aimane-chnaif commented on Sep 22, 2023

NicMendonca commented on Sep 22, 2023

aimane-chnaif commented on Sep 22, 2023

NicMendonca commented on Sep 25, 2023

NicMendonca commented on Sep 25, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions